kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Kreps (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-823) merge 0.8 (51421fcc0111031bb77f779a6f6c00520d526a34) to trunk
Date Tue, 16 Apr 2013 15:27:15 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632925#comment-13632925
] 

Jay Kreps commented on KAFKA-823:
---------------------------------

Comments:
- I think moving Log.append to return a tuple of longs is a worse api as it won't support
extension in the future. This is the spot where we do our iteration of the message set so
it is likely that we will have other stats we want to compute. Let's keep the append info
object.
- If there are wrong values in the append info object they need to be fixed or renamed (shallowCount?)
we can't just leave them there wrong
- You moved back to having the if(assignOffsets) block return the last offset. How come?
- In general I think the logic of using (lastOffset - firstOffset + 1) as the number of appended
messages isn't correct. I think using the shallow message count would be better or passing
back the actual number of messages from the deep iteration which would require some refactoring.
The problem with using this is that when bootstrapping a follower it would flush on every
append for any topic with sparse offsets.

                
> merge 0.8 (51421fcc0111031bb77f779a6f6c00520d526a34) to trunk
> -------------------------------------------------------------
>
>                 Key: KAFKA-823
>                 URL: https://issues.apache.org/jira/browse/KAFKA-823
>             Project: Kafka
>          Issue Type: Task
>          Components: core
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: kafka-823.patch, kafka-823_v2.patch, kafka-823_v3.patch
>
>
> merge 0.8 up to the following commit to trunk
> commit 51421fcc0111031bb77f779a6f6c00520d526a34
> Author: Neha Narkhede <neha.narkhede@gmail.com>
> Date:   Fri Mar 22 09:32:27 2013 -0700
>     KAFKA-816 Reduce noise in Kafka server logs due to NotLeaderForPartitionException;
reviewed by Jun Rao

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message