kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-813) Minor cleanup in Controller
Date Thu, 21 Mar 2013 00:41:15 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608462#comment-13608462
] 

Neha Narkhede commented on KAFKA-813:
-------------------------------------

1.1 Makes sense, we can just live with the existing counter for now.
Also, let's register the controller stats at startup. That way, they at least show a value
of 0 instead of nan.
                
> Minor cleanup in Controller
> ---------------------------
>
>                 Key: KAFKA-813
>                 URL: https://issues.apache.org/jira/browse/KAFKA-813
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: kafka-0.8
>             Fix For: 0.8
>
>         Attachments: kafka-813-v1.patch, kafka-813-v2.patch
>
>
> Before starting work on delete topic support, uploading a patch first to address some
minor hiccups that touch a bunch of files:
> 1. Change PartitionOfflineException to PartitionUnavailableException because in the partition
state machine we mark a partition offline when its leader is down, whereas the PartitionOfflineException
is thrown when all the assigned replicas of the partition are down.
> 2. Change PartitionOfflineRate to UnavailablePartitionRate
> 3. Remove default leader selector from partition state machine's handleStateChange. We
can specify null as default when we don't need to use a leader selector.
> 4. Include controller info in the client id of LeaderAndIsrRequest.
> 5. Rename controllerContext.allleaders to something more meaningful - partitionLeadershipInfo.
> 6. We don't need to put partition in OnlinePartition state in partition state machine
initializeLeaderAndIsrForPartition, the state change occurs in handleStateChange.
> 7. Add todo in handleStateChanges
> 8. Left a comment above ReassignedPartitionLeaderSelector that reassigned replicas are
already in the ISR (this is not true for other leader selectors), renamed the vals in the
selector.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message