Return-Path: X-Original-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CDD50D434 for ; Sat, 8 Sep 2012 12:48:49 +0000 (UTC) Received: (qmail 13254 invoked by uid 500); 8 Sep 2012 12:48:49 -0000 Delivered-To: apmail-incubator-kafka-dev-archive@incubator.apache.org Received: (qmail 13097 invoked by uid 500); 8 Sep 2012 12:48:43 -0000 Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: kafka-dev@incubator.apache.org Delivered-To: mailing list kafka-dev@incubator.apache.org Delivered-To: moderator for kafka-dev@incubator.apache.org Received: (qmail 27849 invoked by uid 99); 8 Sep 2012 08:16:33 -0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of metacret@gmail.com designates 209.85.223.175 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=auirNgrUR/DdJTYLl2jsyEr5VJSfMTAz0Ud0G6NSqbk=; b=QDYCSCfgk63IfHaUzAe8I+E5NMsv9lE11/8E9IAM5HaYdUjHW2Rv7L91Myngim6bRF kzEtoJETKgy6S3NfoZweEm1u1RS0sbjzcBb9NcZMFrhAxvBf+RRzm2NZBPkSxKVP9Xa6 6rj0w1ys7Lbv5DS64mAIJpnd2i7k1AvAuiasII8oj1ab/lzTmoXEHXMq6OoPfHpzeedA D7m2x2TsygWVMDuEEQVsdzco73d7qF1pghjrlt5paMZ8X1yuNZRSCjLR6QLDDoglPCHM satPxk3LE3DUYngiD6Pg7BztzT/WLpLU++ep/aK5Q+cJV1s4StjPNe6vgCeN2nXJFzU1 dLYg== MIME-Version: 1.0 Date: Sat, 8 Sep 2012 01:16:07 -0700 Message-ID: Subject: Question on SessionExpiredListener From: "Bae, Jae Hyeon" To: kafka-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi Kafka dev team While testing Kafka with Zookeeper, when the connection between Kafka and zookeeper was lost, I saw all ephemeral nodes were gone and whole Kafka cluster was down even though connection was restored after a few seconds. I thought it didn't make sense because Kafka has connection state listener but my expectation was wrong because all connection state listener was watching only Expired event with zkclient. As far as I know, Expired event rarely happens. Can I move handleNewSession method implementation to handleStateChanged with KeeperState.SyncConnected? Is it safe to do this? Thank you Best, Jae