Return-Path: X-Original-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-kafka-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0ED1DD13D for ; Wed, 5 Sep 2012 04:03:17 +0000 (UTC) Received: (qmail 73189 invoked by uid 500); 5 Sep 2012 04:03:16 -0000 Delivered-To: apmail-incubator-kafka-dev-archive@incubator.apache.org Received: (qmail 73015 invoked by uid 500); 5 Sep 2012 04:03:10 -0000 Mailing-List: contact kafka-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: kafka-dev@incubator.apache.org Delivered-To: mailing list kafka-dev@incubator.apache.org Received: (qmail 72775 invoked by uid 99); 5 Sep 2012 04:03:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2012 04:03:08 +0000 Date: Wed, 5 Sep 2012 15:03:07 +1100 (NCT) From: "Eli Reisman (JIRA)" To: kafka-dev@incubator.apache.org Message-ID: <1435275109.37197.1346817788045.JavaMail.jiratomcat@arcas> In-Reply-To: <697529230.28475.1340082882752.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (KAFKA-367) StringEncoder/StringDecoder use platform default character set MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Reisman updated KAFKA-367: ------------------------------ Attachment: KAFKA-367-3.patch Is this more like it? This seems right and the decoder related tests seem to be passing, but when I run the suite in SBT on my local machine I get several errors in tests regarding ZooKeeper. I am unaware whether these are due to local test config or genuine trouble. They seem to culminate at the Kafka end in Utils.getObject() at line 675. > StringEncoder/StringDecoder use platform default character set > -------------------------------------------------------------- > > Key: KAFKA-367 > URL: https://issues.apache.org/jira/browse/KAFKA-367 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8 > Reporter: Jay Kreps > Assignee: Eli Reisman > Labels: newbie > Attachments: KAFKA-367-1.patch, KAFKA-367-2.patch, KAFKA-367-3.patch > > > StringEncoder and StringDecoder take the platform default character set. This is bad since the messages they produce are sent off that machine. We should > -- add a new required argument to these that adds the character set and default to UTF-8 rather than the machine setting > -- add a commandline parameter for the console-* tools to let you specify the correct encoding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira