kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Kreps (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-458) remove errorcode from ByteBufferMessageSet
Date Wed, 05 Sep 2012 19:46:07 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449045#comment-13449045
] 

Jay Kreps commented on KAFKA-458:
---------------------------------

Swapnil, this patch look fantastic, very thorough clean up. One issue: in ByteBufferMessageSet
you leave equals() overridden but I think hashCode is no longer overridden (basically the
equals uses the initial offset but the hash code doesn't). This can cause some subtle issues
with use of collections, and is probably a bug.
                
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
>                 Key: KAFKA-458
>                 URL: https://issues.apache.org/jira/browse/KAFKA-458
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Swapnil Ghike
>              Labels: optimization
>             Fix For: 0.8
>
>         Attachments: kafka-458-v1.patch, kafka-458-v2.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in
ByteBufferMessageSet any more.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message