kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Kreps (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-367) StringEncoder/StringDecoder use platform default character set
Date Thu, 06 Sep 2012 19:45:07 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449982#comment-13449982
] 

Jay Kreps commented on KAFKA-367:
---------------------------------

Yeah I think the contract now becomes "your class needs to implement the interface and provide
a constructor that takes Properties, so it does make sense to have this in the class rather
than the trait since we won't know what to do with the properties except in the class.

I think we do need to use the new constructor to make this bug fixed since otherwise we are
still going to pick up the default char set.
                
> StringEncoder/StringDecoder use platform default character set
> --------------------------------------------------------------
>
>                 Key: KAFKA-367
>                 URL: https://issues.apache.org/jira/browse/KAFKA-367
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>            Assignee: Eli Reisman
>              Labels: newbie
>         Attachments: KAFKA-367-1.patch, KAFKA-367-2.patch, KAFKA-367-3.patch, KAFKA-367-3.patch
>
>
> StringEncoder and StringDecoder take the platform default character set. This is bad
since the messages they produce are sent off that machine. We should
> -- add a new required argument to these that adds the character set and default to UTF-8
rather than the machine setting
> -- add a commandline parameter for the console-* tools to let you specify the correct
encoding.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message