kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-490) Check max message size on server instead of producer
Date Tue, 04 Sep 2012 15:32:07 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447753#comment-13447753

Jun Rao commented on KAFKA-490:

Thanks for patch v1. Some comments:

1. DefaultEventHandler.send(): We should log a warning if we get any error in the response,
not just for MessageSizeTooLarge.

2. KafkaApis: 
2.1 Is the change in the file necessary?
2.2 handleProducerRequest(): If produceToLocalLog() returns a response with an error code
on every partition, we can send the response immediately without putting the request into
the purgatory. 

3. SyncProducer.send(): We can get rid of the 2 for loops here. 

> Check max message size on server instead of producer
> ----------------------------------------------------
>                 Key: KAFKA-490
>                 URL: https://issues.apache.org/jira/browse/KAFKA-490
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>              Labels: bug
>             Fix For: 0.8
>         Attachments: kafka-490-v1.patch
>   Original Estimate: 48h
>  Remaining Estimate: 48h
> Message size is checked currently only in SyncProducer and not at the server. Therefore,
non-java clients can push bigger messages to the server. Need a message size check at the
server. Can remove the check from producer side since server can send acks in 0.8.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message