kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Koshy (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-455) ProducerSendThread calls ListBuffer.size a whole bunch. That is a O(n) operation
Date Tue, 11 Sep 2012 21:32:08 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joel Koshy resolved KAFKA-455.
------------------------------

    Resolution: Duplicate

dup of KAFKA-456
                
> ProducerSendThread calls ListBuffer.size a whole bunch. That is a O(n) operation
> --------------------------------------------------------------------------------
>
>                 Key: KAFKA-455
>                 URL: https://issues.apache.org/jira/browse/KAFKA-455
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8, 0.7.1, 0.7.2
>         Environment: NA
>            Reporter: Matthew Rathbone
>            Priority: Minor
>              Labels: newbie
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Hi all,
> So there are various statements throughout the async code that call 'events.size', mostly
for debugging purposes.
> Problem is that this call is O(n), so it could add up if the batch size is high. (it's
a ListBuffer)
> I see this in at least ProducerSendThread (x4), likely more. Will factor this out myself
soon when I start hacking on the project, just wanted to put this somewhere.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message