kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KAFKA-240) implement new producer and consumer request format
Date Thu, 01 Mar 2012 19:40:19 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jun Rao updated KAFKA-240:
--------------------------

    Attachment: kafka-240_unittestfix_delta.patch

Joe, 

There are 2 reasons why the unit test fails.
1. Some default values for ProducerRequest are not set consistently.
2. The bigger issue is that in scala, Array equal is only testing equal on reference, not
the actual value. This is different from how other Seq classes like List behave. To fix that,
I have to explicit define equal in ProdueRequest and TopicData.

Attached is a patch of only 4 scala files that I modified. Apply your v4 patch, revert those
4 files and apply my patch. The unit test passes now. 

A few other things:
9. When deserilizing bytes to ProducerRequest, we need to set version id.
10. In KafkaApi, we should send no ack on ProducerRequest since the producer is not reading
the response yet. Add a comment that this will be fixed in kafka-49.

Once the above 2 issues are addressed, you can just commit without further review. Finally,
would you mind committing after kafka-239? That patch changed quite a few unit tests and may
take a bit more time to refactor.

                
> implement new producer and consumer request format
> --------------------------------------------------
>
>                 Key: KAFKA-240
>                 URL: https://issues.apache.org/jira/browse/KAFKA-240
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>              Labels: fetch, replication, wireprotocol
>             Fix For: 0.8
>
>         Attachments: KAFKA-240-FetchRequest-v1.patch, KAFKA-240-FetchRequest-v2.patch,
KAFKA-240-FetchRequest-validation-v1.patch, KAFKA-240.ProducerRequest.v2.patch, KAFKA-240.ProducerRequest.v3.patch,
KAFKA-240.ProducerRequest.v4.patch, KAFKA-240.v3.patch, kafka-240_unittestfix_delta.patch
>
>
> We want to change the producer/consumer request/response format according to the discussion
in the following wiki:
> https://cwiki.apache.org/confluence/display/KAFKA/New+Wire+Format+Proposal

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message