kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prashanth Menon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.
Date Wed, 07 Mar 2012 03:44:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223944#comment-13223944
] 

Prashanth Menon commented on KAFKA-49:
--------------------------------------

I've attached a patch for this.  A few comments:

- Modified ProducerResponse
- Broker does not actually wait for replica ACKS.  This will be done with KAFKA-44.
- Sync producer has been modified to wait for response from broker.  Async producer isn't
aware of request level errors, this will require a separate ticket.
- Some general cleanup on producer request, async producer and removal of MultiProduce request
key.

One oddity is since we use Arrays in the request and response, it breaks the case class equality/hashcode
logic since Java's arrays are broken.  We should probably make them Seq's (separate JIRA?)
or WrappedArrays.

                
> Add acknowledgement to the produce request.
> -------------------------------------------
>
>                 Key: KAFKA-49
>                 URL: https://issues.apache.org/jira/browse/KAFKA-49
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Prashanth Menon
>             Fix For: 0.8
>
>         Attachments: KAFKA-49-v1.patch
>
>
> Currently, the produce request doesn't get acknowledged. We need to have a broker send
a response to the producer and have the producer wait for the response before sending the
next request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message