From commits-return-10929-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Jan 3 00:04:43 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 44874180662 for ; Thu, 3 Jan 2019 00:04:43 +0100 (CET) Received: (qmail 20867 invoked by uid 500); 2 Jan 2019 23:04:42 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 20858 invoked by uid 99); 2 Jan 2019 23:04:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jan 2019 23:04:42 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id A908D821AE; Wed, 2 Jan 2019 23:04:41 +0000 (UTC) Date: Wed, 02 Jan 2019 23:04:40 +0000 To: "commits@kafka.apache.org" Subject: [kafka] branch 2.1 updated: KAFKA-5503; Idempotent producer ignores shutdown while fetching ProducerId (#5881) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <154647028011.13481.3136030203649529985@gitbox.apache.org> From: jgus@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: kafka X-Git-Refname: refs/heads/2.1 X-Git-Reftype: branch X-Git-Oldrev: ed089211f7dff6db66f2cb7dacadc98d70e49b20 X-Git-Newrev: 4b9a3ba59b6761b60e3a661fa8c1dd25e8653f82 X-Git-Rev: 4b9a3ba59b6761b60e3a661fa8c1dd25e8653f82 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. jgus pushed a commit to branch 2.1 in repository https://gitbox.apache.org/repos/asf/kafka.git The following commit(s) were added to refs/heads/2.1 by this push: new 4b9a3ba KAFKA-5503; Idempotent producer ignores shutdown while fetching ProducerId (#5881) 4b9a3ba is described below commit 4b9a3ba59b6761b60e3a661fa8c1dd25e8653f82 Author: layfe AuthorDate: Thu Jan 3 02:00:40 2019 +0300 KAFKA-5503; Idempotent producer ignores shutdown while fetching ProducerId (#5881) Check `running` in `Sender.maybeWaitForProducerId` to ensure that the producer can be closed while awaiting initialization of the producerId. Reviewers: Jason Gustafson --- .../main/java/org/apache/kafka/clients/producer/internals/Sender.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java b/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java index 644f456..1879d6f 100644 --- a/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java +++ b/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java @@ -494,7 +494,7 @@ public class Sender implements Runnable { } private void maybeWaitForProducerId() { - while (!transactionManager.hasProducerId() && !transactionManager.hasError()) { + while (running && !transactionManager.hasProducerId() && !transactionManager.hasError()) { Node node = null; try { node = awaitLeastLoadedNodeReady(requestTimeoutMs);