From commits-return-10662-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Sun Oct 28 17:45:34 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A2F52180671 for ; Sun, 28 Oct 2018 17:45:33 +0100 (CET) Received: (qmail 49804 invoked by uid 500); 28 Oct 2018 16:45:32 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 49795 invoked by uid 99); 28 Oct 2018 16:45:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Oct 2018 16:45:32 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 19C9D829CB; Sun, 28 Oct 2018 16:45:32 +0000 (UTC) Date: Sun, 28 Oct 2018 16:45:31 +0000 To: "commits@kafka.apache.org" Subject: [kafka] branch 1.0 updated: MINOR: Remove unintentional tilde character from kafka-run-class.bat script MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <154074513050.8151.15753442143754255975@gitbox.apache.org> From: manikumar@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: kafka X-Git-Refname: refs/heads/1.0 X-Git-Reftype: branch X-Git-Oldrev: 11e84e7d07e3feee8a46310962f895a273d3ed09 X-Git-Newrev: 4d3910f106b78654fd55d6530f856633f4e0c610 X-Git-Rev: 4d3910f106b78654fd55d6530f856633f4e0c610 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. manikumar pushed a commit to branch 1.0 in repository https://gitbox.apache.org/repos/asf/kafka.git The following commit(s) were added to refs/heads/1.0 by this push: new 4d3910f MINOR: Remove unintentional tilde character from kafka-run-class.bat script 4d3910f is described below commit 4d3910f106b78654fd55d6530f856633f4e0c610 Author: u214578 AuthorDate: Sun Oct 28 11:59:08 2018 +0530 MINOR: Remove unintentional tilde character from kafka-run-class.bat script It seems a tipo was made on a avariable for the log dir with commit 81e789ae3dc6ea8369db181c5aef440491d74f19. Then Windows tries to access by default the /log directory which of cause not exists. klesta490 Is it ok so? Or was the tilde ~ intentional? To test: On Windows with the a fresh downloaded Kafka, adapt the properties: * dataDir in config/zookeeper.properties with what you want, windows-compatible * log.dirs in config/server.properties with what you want, windows-compatible and executes: bin\windows\zookeeper-server-start.bat config\zookeeper.properties Author: u214578 Reviewers: Vladimír Kleštinec , Vahid Hashemian Closes #5837 from florianhof/feature/fix_windows_log_param --- bin/windows/kafka-run-class.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/windows/kafka-run-class.bat b/bin/windows/kafka-run-class.bat index 1dfd9a5..a21171b 100755 --- a/bin/windows/kafka-run-class.bat +++ b/bin/windows/kafka-run-class.bat @@ -111,7 +111,7 @@ IF ["%JMX_PORT%"] NEQ [""] ( rem Log directory to use IF ["%LOG_DIR%"] EQU [""] ( - set LOG_DIR="%BASE_DIR~%/logs" + set LOG_DIR="%BASE_DIR%/logs" ) rem Log4j settings