kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maniku...@apache.org
Subject [kafka] branch 2.1 updated: MINOR: Remove unintentional tilde character from kafka-run-class.bat script
Date Sun, 28 Oct 2018 16:35:38 GMT
This is an automated email from the ASF dual-hosted git repository.

manikumar pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.1 by this push:
     new f402c37  MINOR: Remove unintentional tilde character from kafka-run-class.bat script
f402c37 is described below

commit f402c37ce3baa068a2d31e792e8d674aca2f0ef8
Author: u214578 <florian.hof@sbb.ch>
AuthorDate: Sun Oct 28 11:59:08 2018 +0530

    MINOR: Remove unintentional tilde character from kafka-run-class.bat script
    
    It seems a tipo was made on a avariable for the log dir with commit 81e789ae3dc6ea8369db181c5aef440491d74f19.
Then Windows tries to access by default the /log directory which of cause not exists.
    klesta490 Is it ok so? Or was the tilde ~ intentional?
    
    To test:
    On Windows with the a fresh downloaded Kafka, adapt the properties:
    * dataDir in config/zookeeper.properties with what you want, windows-compatible
    * log.dirs in config/server.properties with what you want, windows-compatible
    and executes:
    bin\windows\zookeeper-server-start.bat config\zookeeper.properties
    
    Author: u214578 <florian.hof@sbb.ch>
    
    Reviewers: Vladim√≠r KleŇ°tinec <klestinec@gmail.com>, Vahid Hashemian <vahid.hashemian@gmail.com>
    
    Closes #5837 from florianhof/feature/fix_windows_log_param
---
 bin/windows/kafka-run-class.bat | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/windows/kafka-run-class.bat b/bin/windows/kafka-run-class.bat
index 1dfd9a5..a21171b 100755
--- a/bin/windows/kafka-run-class.bat
+++ b/bin/windows/kafka-run-class.bat
@@ -111,7 +111,7 @@ IF ["%JMX_PORT%"] NEQ [""] (
 
 rem Log directory to use
 IF ["%LOG_DIR%"] EQU [""] (
-    set LOG_DIR="%BASE_DIR~%/logs"
+    set LOG_DIR="%BASE_DIR%/logs"
 )
 
 rem Log4j settings


Mime
View raw message