kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject [kafka] branch 2.0 updated: MINOR: Fix undefined variable in Connect test
Date Wed, 24 Oct 2018 20:18:02 GMT
This is an automated email from the ASF dual-hosted git repository.

ewencp pushed a commit to branch 2.0
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.0 by this push:
     new dc89548  MINOR: Fix undefined variable in Connect test
dc89548 is described below

commit dc89548be61e2bcba90ac0ff6875813dec643e32
Author: Randall Hauch <rhauch@gmail.com>
AuthorDate: Wed Oct 24 13:16:34 2018 -0700

    MINOR: Fix undefined variable in Connect test
    
    Corrects an error in the system tests:
    ```
    07:55:45 [ERROR:2018-10-23 07:55:45,738]: Failed to import kafkatest.tests.connect.connect_test,
which may indicate a broken test that cannot be loaded: NameError: name 'EXTERNAL_CONFIGS_FILE'
is not defined
    ```
    
    The constant is defined in the [services/connect.py](https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/connect.py#L43)
file in the `ConnectServiceBase` class, but the problem is in the [tests/connect/connect_test.py](https://github.com/apache/kafka/blob/trunk/tests/kafkatest/tests/connect/connect_test.py#L50)
`ConnectStandaloneFileTest`, which does *not* extend the `ConnectServiceBase class`. Suggestions
welcome to be able to reuse that variable without duplicating t [...]
    
    System test run with this PR: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2004/
    
    If approved, this should be merged as far back as the `2.0` branch.
    
    Author: Randall Hauch <rhauch@gmail.com>
    
    Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>
    
    Closes #5832 from rhauch/fix-connect-externals-tests
    
    (cherry picked from commit 8b1d705404cf52b508874c7ae0ab1d86cab83bfc)
    Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
---
 tests/kafkatest/tests/connect/connect_test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kafkatest/tests/connect/connect_test.py b/tests/kafkatest/tests/connect/connect_test.py
index e2618e9..2d8ac2d 100644
--- a/tests/kafkatest/tests/connect/connect_test.py
+++ b/tests/kafkatest/tests/connect/connect_test.py
@@ -47,7 +47,7 @@ class ConnectStandaloneFileTest(Test):
 
     OFFSETS_FILE = "/mnt/connect.offsets"
 
-    TOPIC = "${file:" + EXTERNAL_CONFIGS_FILE + ":topic.external}"
+    TOPIC = "${file:/mnt/connect/connect-file-external.properties:topic.external}"
     TOPIC_TEST = "test"
 
     FIRST_INPUT_LIST = ["foo", "bar", "baz"]


Mime
View raw message