From commits-return-9906-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Fri Jun 29 16:38:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8FE67180663 for ; Fri, 29 Jun 2018 16:38:50 +0200 (CEST) Received: (qmail 96285 invoked by uid 500); 29 Jun 2018 14:38:49 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 96276 invoked by uid 99); 29 Jun 2018 14:38:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jun 2018 14:38:49 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id D3DFE85837; Fri, 29 Jun 2018 14:38:48 +0000 (UTC) Date: Fri, 29 Jun 2018 14:38:48 +0000 To: "commits@kafka.apache.org" Subject: [kafka] branch 2.0 updated: KAFKA-7111: Log error connecting to node at a higher log level (#5312) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <153028312800.14898.564090062489058391@gitbox.apache.org> From: rsivaram@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: kafka X-Git-Refname: refs/heads/2.0 X-Git-Reftype: branch X-Git-Oldrev: 6ab9d161e665b681b2982c80e265a4edcfff594e X-Git-Newrev: d83f2c342ede42f41080fb64f2df38d62894707a X-Git-Rev: d83f2c342ede42f41080fb64f2df38d62894707a X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. rsivaram pushed a commit to branch 2.0 in repository https://gitbox.apache.org/repos/asf/kafka.git The following commit(s) were added to refs/heads/2.0 by this push: new d83f2c3 KAFKA-7111: Log error connecting to node at a higher log level (#5312) d83f2c3 is described below commit d83f2c342ede42f41080fb64f2df38d62894707a Author: Stanislav Kozlovski AuthorDate: Fri Jun 29 15:37:14 2018 +0100 KAFKA-7111: Log error connecting to node at a higher log level (#5312) There are cases where the broker would return an unresolve-able address (e.g broker inside a docker network while client is outside) and the client would not log any information as to why it is timing out, since the default log level does not print DEBUG messages. Changing this log level will enable easier troubleshooting in such circumstances. This change does not change the logs shown on transient failures like a broker failure. --- clients/src/main/java/org/apache/kafka/clients/NetworkClient.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java b/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java index ea16ac9..720a781 100644 --- a/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java +++ b/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java @@ -869,7 +869,7 @@ public class NetworkClient implements KafkaClient { connectionStates.disconnected(nodeConnectionId, now); /* maybe the problem is our metadata, update it */ metadataUpdater.requestUpdate(); - log.debug("Error connecting to node {}", node, e); + log.warn("Error connecting to node {}", node, e); } }