kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject [kafka] branch trunk updated: MINOR: Remove the unused field in DelegatingClassLoader
Date Wed, 13 Jun 2018 04:04:12 GMT
This is an automated email from the ASF dual-hosted git repository.

ewencp pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 70e13f0  MINOR: Remove the unused field in DelegatingClassLoader
70e13f0 is described below

commit 70e13f032e6f594d021787583e1982225eea9388
Author: Chia-Ping Tsai <chia7712@gmail.com>
AuthorDate: Tue Jun 12 21:03:19 2018 -0700

    MINOR: Remove the unused field in DelegatingClassLoader
    
    After [3173](https://github.com/apache/kafka/commit/e0150a25e8), the field "activePaths"
is not used anymore.
    
    Author: Chia-Ping Tsai <chia7712@gmail.com>
    
    Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>
    
    Closes #4984 from chia7712/remove_unused_field_from_DelegatingClassLoader
---
 .../kafka/connect/runtime/isolation/DelegatingClassLoader.java      | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
index e7a1712..dd387c4 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
@@ -72,7 +72,6 @@ public class DelegatingClassLoader extends URLClassLoader {
     private final SortedSet<PluginDesc<ConfigProvider>> configProviders;
     private final SortedSet<PluginDesc<ConnectRestExtension>> restExtensions;
     private final List<String> pluginPaths;
-    private final Map<Path, PluginClassLoader> activePaths;
 
     private static final String MANIFEST_PREFIX = "META-INF/services/";
     private static final Class[] SERVICE_LOADER_PLUGINS = new Class[] {ConnectRestExtension.class,
ConfigProvider.class};
@@ -85,7 +84,6 @@ public class DelegatingClassLoader extends URLClassLoader {
         this.pluginPaths = pluginPaths;
         this.pluginLoaders = new HashMap<>();
         this.aliases = new HashMap<>();
-        this.activePaths = new HashMap<>();
         this.connectors = new TreeSet<>();
         this.converters = new TreeSet<>();
         this.headerConverters = new TreeSet<>();
@@ -239,10 +237,6 @@ public class DelegatingClassLoader extends URLClassLoader {
         PluginScanResult plugins = scanPluginPath(loader, urls);
         log.info("Registered loader: {}", loader);
         if (!plugins.isEmpty()) {
-            if (loader instanceof PluginClassLoader) {
-                activePaths.put(pluginLocation, (PluginClassLoader) loader);
-            }
-
             addPlugins(plugins.connectors(), loader);
             connectors.addAll(plugins.connectors());
             addPlugins(plugins.converters(), loader);

-- 
To stop receiving notification emails like this one, please contact
ewencp@apache.org.

Mime
View raw message