kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: MINOR: fix flakiness in testDeleteAcls
Date Thu, 25 May 2017 10:21:02 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk cea319a4a -> a10990f44


MINOR: fix flakiness in testDeleteAcls

This call to isCompletedExceptionally introduced a race condition
because the future might not have been completed.  assertFutureError
checks that the exception is present and of the correct type in any
case, so the call was not necessary.

Author: Colin P. Mccabe <cmccabe@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #3139 from cmccabe/fix-test-deleteacls


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/a10990f4
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/a10990f4
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/a10990f4

Branch: refs/heads/trunk
Commit: a10990f44b1a4f8345eae7ebfc9c571bfd0447c3
Parents: cea319a
Author: Colin P. Mccabe <cmccabe@confluent.io>
Authored: Thu May 25 11:21:00 2017 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Thu May 25 11:21:00 2017 +0100

----------------------------------------------------------------------
 .../java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java   | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/a10990f4/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
----------------------------------------------------------------------
diff --git a/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
b/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
index 62c7dde..2ef654d 100644
--- a/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
+++ b/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
@@ -288,7 +288,6 @@ public class KafkaAdminClientTest {
             assertEquals(ACL1, filter1Results.acls().get(0).acl());
             assertEquals(null, filter1Results.acls().get(1).exception());
             assertEquals(ACL2, filter1Results.acls().get(1).acl());
-            assertTrue(filterResults.get(FILTER2).isCompletedExceptionally());
             assertFutureError(filterResults.get(FILTER2), SecurityDisabledException.class);
             assertFutureError(results.all(), SecurityDisabledException.class);
 


Mime
View raw message