Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BC7E6200BBD for ; Tue, 8 Nov 2016 21:10:18 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BB0C7160B0A; Tue, 8 Nov 2016 20:10:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0C458160AD0 for ; Tue, 8 Nov 2016 21:10:17 +0100 (CET) Received: (qmail 34308 invoked by uid 500); 8 Nov 2016 20:10:17 -0000 Mailing-List: contact commits-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list commits@kafka.apache.org Received: (qmail 34299 invoked by uid 99); 8 Nov 2016 20:10:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Nov 2016 20:10:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1B327E098A; Tue, 8 Nov 2016 20:10:17 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: guozhang@apache.org To: commits@kafka.apache.org Message-Id: <55eff311710043949fddf87b252fb565@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: kafka git commit: MINOR: remove commented out code and System.out.println Date: Tue, 8 Nov 2016 20:10:17 +0000 (UTC) archived-at: Tue, 08 Nov 2016 20:10:18 -0000 Repository: kafka Updated Branches: refs/heads/trunk 471a2ab17 -> 92287849e MINOR: remove commented out code and System.out.println Remove commented out code and System.out.println from KTableKTableJoinIntegrationTest Author: Damian Guy Reviewers: Matthias J. Sax, Eno Thereska, Guozhang Wang Closes #2092 from dguy/cleanup-comments Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/92287849 Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/92287849 Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/92287849 Branch: refs/heads/trunk Commit: 92287849e46ee0dad360fcd971c6207aa11777a7 Parents: 471a2ab Author: Damian Guy Authored: Tue Nov 8 12:10:13 2016 -0800 Committer: Guozhang Wang Committed: Tue Nov 8 12:10:13 2016 -0800 ---------------------------------------------------------------------- .../KTableKTableJoinIntegrationTest.java | 31 -------------------- 1 file changed, 31 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/92287849/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java ---------------------------------------------------------------------- diff --git a/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java b/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java index 2cd3859..5a0d368 100644 --- a/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableJoinIntegrationTest.java @@ -71,49 +71,26 @@ public class KTableKTableJoinIntegrationTest { public static Object[] parameters() { return new Object[][]{ {JoinType.INNER, JoinType.INNER, Arrays.asList( -// new KeyValue<>("a", null), -// new KeyValue<>("b", null), -// new KeyValue<>("c", null), -// new KeyValue<>("a", null), -// new KeyValue<>("b", null), new KeyValue<>("b", "B1-B2-B3")//, -// new KeyValue<>("c", null) )}, {JoinType.INNER, JoinType.LEFT, Arrays.asList( -// new KeyValue<>("a", null), -// new KeyValue<>("b", null), -// new KeyValue<>("c", null), -// new KeyValue<>("a", null), -// new KeyValue<>("b", null), new KeyValue<>("b", "B1-B2-B3")//, -// new KeyValue<>("c", null) )}, {JoinType.INNER, JoinType.OUTER, Arrays.asList( new KeyValue<>("a", "null-A3"), new KeyValue<>("b", "null-B3"), new KeyValue<>("c", "null-C3"), -// new KeyValue<>("a", "null-A3"), -// new KeyValue<>("b", "null-B3"), new KeyValue<>("b", "B1-B2-B3")//, -// new KeyValue<>("c", "null-C3") )}, {JoinType.LEFT, JoinType.INNER, Arrays.asList( -// new KeyValue<>("a", null), -// new KeyValue<>("b", null), -// new KeyValue<>("c", null), new KeyValue<>("a", "A1-null-A3"), new KeyValue<>("b", "B1-null-B3"), new KeyValue<>("b", "B1-B2-B3")//, -// new KeyValue<>("c", null) )}, {JoinType.LEFT, JoinType.LEFT, Arrays.asList( -// new KeyValue<>("a", null), -// new KeyValue<>("b", null), -// new KeyValue<>("c", null), new KeyValue<>("a", "A1-null-A3"), new KeyValue<>("b", "B1-null-B3"), new KeyValue<>("b", "B1-B2-B3")//, -// new KeyValue<>("c", null) )}, {JoinType.LEFT, JoinType.OUTER, Arrays.asList( new KeyValue<>("a", "null-A3"), @@ -122,21 +99,14 @@ public class KTableKTableJoinIntegrationTest { new KeyValue<>("a", "A1-null-A3"), new KeyValue<>("b", "B1-null-B3"), new KeyValue<>("b", "B1-B2-B3")//, -// new KeyValue<>("c", "null-C3") )}, {JoinType.OUTER, JoinType.INNER, Arrays.asList( -// new KeyValue<>("a", null), -// new KeyValue<>("b", null), -// new KeyValue<>("c", null), new KeyValue<>("a", "A1-null-A3"), new KeyValue<>("b", "B1-null-B3"), new KeyValue<>("b", "B1-B2-B3"), new KeyValue<>("c", "null-C2-C3") )}, {JoinType.OUTER, JoinType.LEFT, Arrays.asList( -// new KeyValue<>("a", null), -// new KeyValue<>("b", null), -// new KeyValue<>("c", null), new KeyValue<>("a", "A1-null-A3"), new KeyValue<>("b", "B1-null-B3"), new KeyValue<>("b", "B1-B2-B3"), @@ -262,7 +232,6 @@ public class KTableKTableJoinIntegrationTest { @Test public void KTableKTableJoin() throws Exception { - System.out.println("join: " + joinType1 + "-" + joinType2); streamsConfig.put(StreamsConfig.APPLICATION_ID_CONFIG, joinType1 + "-" + joinType2 + "-ktable-ktable-join"); streams = prepareTopology();