kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject kafka git commit: KAFKA-4265; Run replication quotas test with producer acks=1
Date Sat, 08 Oct 2016 15:11:08 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 6b91f83fb -> 44d18d273


KAFKA-4265; Run replication quotas test with producer acks=1

Test expects all records to be published successfully, which cannot be guaranteed with acks=0
since failures are not retried.

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Ben Stopford <benstopford@gmail.com>, Ismael Juma <ismael@juma.me.uk>

Closes #1991 from rajinisivaram/KAFKA-4265


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/44d18d27
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/44d18d27
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/44d18d27

Branch: refs/heads/trunk
Commit: 44d18d273c36bb76fa16baec68a9294d697a1c9b
Parents: 6b91f83
Author: Rajini Sivaram <rajinisivaram@googlemail.com>
Authored: Sat Oct 8 12:22:34 2016 +0100
Committer: Ismael Juma <ismael@juma.me.uk>
Committed: Sat Oct 8 12:22:34 2016 +0100

----------------------------------------------------------------------
 core/src/test/scala/unit/kafka/server/ReplicationQuotasTest.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/44d18d27/core/src/test/scala/unit/kafka/server/ReplicationQuotasTest.scala
----------------------------------------------------------------------
diff --git a/core/src/test/scala/unit/kafka/server/ReplicationQuotasTest.scala b/core/src/test/scala/unit/kafka/server/ReplicationQuotasTest.scala
index 511052d..825b2b4 100644
--- a/core/src/test/scala/unit/kafka/server/ReplicationQuotasTest.scala
+++ b/core/src/test/scala/unit/kafka/server/ReplicationQuotasTest.scala
@@ -119,7 +119,7 @@ class ReplicationQuotasTest extends ZooKeeperTestHarness {
       changeTopicConfig(zkUtils, topic, propsWith(FollowerReplicationThrottledReplicasProp,
"0:106,1:106,2:106,3:107,4:107,5:107"))
 
     //Add data equally to each partition
-    producer = createNewProducer(getBrokerListStrFromServers(brokers), retries = 5, acks
= 0)
+    producer = createNewProducer(getBrokerListStrFromServers(brokers), retries = 5, acks
= 1)
     (0 until msgCount).foreach { x =>
       (0 to 7).foreach { partition =>
         producer.send(new ProducerRecord(topic, partition, null, msg))


Mime
View raw message