kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject kafka git commit: MINOR: Mention `log.message.format.version=0.10.0` in rolling upgrade section
Date Sun, 19 Jun 2016 23:03:58 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.10.0 968e44cac -> 412d2da29


MINOR: Mention `log.message.format.version=0.10.0` in rolling upgrade section

We had mentioned this step in the performance impact section in the middle of a long paragraph,
which made it easy to miss. I also tweaked the reason for setting `log.message.format.version`
as it could be misinterpreted previously.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1514 from ijuma/tweak-upgrade-notes

(cherry picked from commit b9f1c60328da8a494424e30e7ebcb75d31c6fe85)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/412d2da2
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/412d2da2
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/412d2da2

Branch: refs/heads/0.10.0
Commit: 412d2da29a7213faad4689758ecccbb55d53d415
Parents: 968e44c
Author: Ismael Juma <ismael@juma.me.uk>
Authored: Sun Jun 19 16:03:40 2016 -0700
Committer: Ewen Cheslack-Postava <me@ewencp.org>
Committed: Sun Jun 19 16:03:48 2016 -0700

----------------------------------------------------------------------
 docs/upgrade.html | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/412d2da2/docs/upgrade.html
----------------------------------------------------------------------
diff --git a/docs/upgrade.html b/docs/upgrade.html
index dec0808..a9a1443 100644
--- a/docs/upgrade.html
+++ b/docs/upgrade.html
@@ -31,12 +31,15 @@ work with 0.10.0.x brokers. Therefore, 0.9.0.0 clients should be upgraded
to 0.9
 
 <ol>
     <li> Update server.properties file on all brokers and add the following property:
inter.broker.protocol.version=CURRENT_KAFKA_VERSION (e.g. 0.8.2 or 0.9.0.0).
-         We recommend that users set log.message.format.version=CURRENT_KAFKA_VERSION as
well to avoid a performance regression
-         during upgrade. See <a href="#upgrade_10_performance_impact">potential performance
impact during upgrade</a> for the details.
+         We recommend that users set log.message.format.version=CURRENT_KAFKA_VERSION as
well to ensure that performance of 0.8 and 0.9 consumers is not affected
+         during the upgrade. See <a href="#upgrade_10_performance_impact">potential
performance impact during upgrade</a> for the details.
     </li>
     <li> Upgrade the brokers. This can be done a broker at a time by simply bringing
it down, updating the code, and restarting it. </li>
     <li> Once the entire cluster is upgraded, bump the protocol version by editing
inter.broker.protocol.version and setting it to 0.10.0.0. </li>
     <li> Restart the brokers one by one for the new protocol version to take effect.
</li>
+    <li> Once most consumers have been upgraded to 0.10.0 and if you followed the recommendation
to set log.message.format.version=CURRENT_KAFKA_VERSION, change
+         log.message.format.version to 0.10.0 on each broker and restart them one by one.
+    </li>
 </ol>
 
 <p><b>Note:</b> If you are willing to accept downtime, you can simply take
all the brokers down, update the code and start all of them. They will start with the new
protocol by default.


Mime
View raw message