kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ewe...@apache.org
Subject kafka git commit: MINOR: Updating comment that fell out of sync with code
Date Wed, 16 Dec 2015 00:18:58 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 3432e85f6 -> fdac34e6a


MINOR: Updating comment that fell out of sync with code

Author: Gwen Shapira <cshapi@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #681 from gwenshap/minor-herder-comment


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/fdac34e6
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/fdac34e6
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/fdac34e6

Branch: refs/heads/trunk
Commit: fdac34e6ab2a7760c170f53556fec7dca8ee9b22
Parents: 3432e85
Author: Gwen Shapira <cshapi@gmail.com>
Authored: Tue Dec 15 16:18:39 2015 -0800
Committer: Ewen Cheslack-Postava <me@ewencp.org>
Committed: Tue Dec 15 16:18:39 2015 -0800

----------------------------------------------------------------------
 .../apache/kafka/connect/runtime/HerderConnectorContext.java  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/fdac34e6/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/HerderConnectorContext.java
----------------------------------------------------------------------
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/HerderConnectorContext.java
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/HerderConnectorContext.java
index 070aa20..e3294ef 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/HerderConnectorContext.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/HerderConnectorContext.java
@@ -20,8 +20,7 @@ package org.apache.kafka.connect.runtime;
 import org.apache.kafka.connect.connector.ConnectorContext;
 
 /**
- * ConnectorContext for use with the StandaloneHerder, which maintains all connectors and
tasks
- * in a single process.
+ * ConnectorContext for use with a Herder
  */
 public class HerderConnectorContext implements ConnectorContext {
 
@@ -35,8 +34,8 @@ public class HerderConnectorContext implements ConnectorContext {
 
     @Override
     public void requestTaskReconfiguration() {
-        // This is trivial to forward since there is only one herder and it's in memory in
this
-        // process
+        // Local herder runs in memory in this process
+        // Distributed herder will forward the request to the leader if needed
         herder.requestTaskReconfiguration(connectorName);
     }
 }


Mime
View raw message