kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject svn commit: r1673245 - /kafka/site/contributing.html
Date Mon, 13 Apr 2015 17:29:12 GMT
Author: junrao
Date: Mon Apr 13 17:29:11 2015
New Revision: 1673245

URL: http://svn.apache.org/r1673245
Log:
Modify patch review process

Modified:
    kafka/site/contributing.html

Modified: kafka/site/contributing.html
URL: http://svn.apache.org/viewvc/kafka/site/contributing.html?rev=1673245&r1=1673244&r2=1673245&view=diff
==============================================================================
--- kafka/site/contributing.html (original)
+++ kafka/site/contributing.html Mon Apr 13 17:29:11 2015
@@ -15,8 +15,8 @@ To submit a patch for inclusion please d
 	<li>If the patch is non-trivial we would prefer it come with some unit tests that
cover the new functionality.</li>
 	<li>If you are introducing a completely new feature or API it is a good idea to start
a wiki and get consensus on the basic design first.</li>
 	<li>Make sure you have observed the recommendations in the <a href="coding-guide.html">style
guide</a>.</li>
-	<li>Open a <a href="https://issues.apache.org/jira/browse/KAFKA">JIRA</a>
ticket describing the patch and attach your patch to the JIRA. Include in the JIRA information
about the issue and the approach you took in fixing it (if this isn't obvious). Creating the
JIRA will automatically send an email to the developer email list alerting us of the new issue.</li>
-	<li>It is our job to follow up on patches in a timely fashion. <a href="mailto:
dev@kafka.apache.org">Nag us</a> if we aren't doing our job (sometimes we drop things).</li>
+	<li>Open a <a href="https://issues.apache.org/jira/browse/KAFKA">JIRA</a>
ticket describing the patch and attach your patch to the JIRA. Include in the JIRA information
about the issue and the approach you took in fixing it (if this isn't obvious). Also, mark
the jira as "Patch Available" by clicking on the "Submit Patch" button (this is done automatically
if you use the code review tool below). Creating the JIRA will automatically send an email
to the developer email list alerting us of the new issue.</li>
+	<li>It is our job to follow up on patches in a timely fashion. <a href="mailto:
dev@kafka.apache.org">Nag us</a> if we aren't doing our job (sometimes we drop things).
If the patch needs improvement, the reviwer will mark the jira back to "In Progress" after
reviewing.</li>
 </ul>
 
 If you will be contributing multiple non-trivial patches it may be worth using our code review
script which helps to integrate git, JIRA, and review board. You can find instructions on
this tool <a href="https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review">here</a>.



Mime
View raw message