kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jjko...@apache.org
Subject git commit: KAFKA-1550; Patch review tool should use git format-patch for patch generation; reviewed by Guozhang Wang and Joel Koshy
Date Tue, 05 Aug 2014 21:48:21 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 0386790e7 -> 09690e339


KAFKA-1550; Patch review tool should use git format-patch for patch generation; reviewed by
Guozhang Wang and Joel Koshy


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/09690e33
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/09690e33
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/09690e33

Branch: refs/heads/trunk
Commit: 09690e339aabea6e9141f7e2ddd50449cc1c9180
Parents: 0386790
Author: Dong Lin <lindong28@gmail.com>
Authored: Tue Aug 5 14:28:11 2014 -0700
Committer: Joel Koshy <jjkoshy@gmail.com>
Committed: Tue Aug 5 14:47:51 2014 -0700

----------------------------------------------------------------------
 kafka-patch-review.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/09690e33/kafka-patch-review.py
----------------------------------------------------------------------
diff --git a/kafka-patch-review.py b/kafka-patch-review.py
index dc45549..89afc84 100644
--- a/kafka-patch-review.py
+++ b/kafka-patch-review.py
@@ -105,11 +105,13 @@ def main():
       print 'ERROR: Your reviewboard was not created/updated. Please run the script with
the --debug option to troubleshoot the problem'
       p.close()
       sys.exit(1)
-  p.close()
+  if p.close() != None:
+    print 'ERROR: reviewboard update failed. Exiting.'
+    sys.exit(1)
   if opt.debug:
     print 'rb url=',rb_url
 
-  git_command="git diff " + opt.branch + " > " + patch_file
+  git_command="git format-patch " + opt.branch + " --stdout > " + patch_file
   if opt.debug:
     print git_command
   p=os.popen(git_command)


Mime
View raw message