kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject git commit: fix for scala 2.10.1 compilation issued introduced in kafka-1117
Date Thu, 21 Nov 2013 05:42:17 GMT
Updated Branches:
  refs/heads/trunk c2dd071b5 -> cd81d37ac


fix for scala 2.10.1 compilation issued introduced in kafka-1117


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/cd81d37a
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/cd81d37a
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/cd81d37a

Branch: refs/heads/trunk
Commit: cd81d37ac872654c0cc68fab830ee457c56b7c6a
Parents: c2dd071
Author: Jun Rao <junrao@gmail.com>
Authored: Wed Nov 20 21:42:24 2013 -0800
Committer: Jun Rao <junrao@gmail.com>
Committed: Wed Nov 20 21:42:46 2013 -0800

----------------------------------------------------------------------
 core/src/main/scala/kafka/api/FetchResponse.scala            | 4 ----
 .../unit/kafka/api/RequestResponseSerializationTest.scala    | 8 ++++----
 2 files changed, 4 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/cd81d37a/core/src/main/scala/kafka/api/FetchResponse.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/api/FetchResponse.scala b/core/src/main/scala/kafka/api/FetchResponse.scala
index e528742..d117f10 100644
--- a/core/src/main/scala/kafka/api/FetchResponse.scala
+++ b/core/src/main/scala/kafka/api/FetchResponse.scala
@@ -42,11 +42,7 @@ object FetchResponsePartitionData {
 }
 
 case class FetchResponsePartitionData(error: Short = ErrorMapping.NoError, hw: Long = -1L,
messages: MessageSet) {
-
   val sizeInBytes = FetchResponsePartitionData.headerSize + messages.sizeInBytes
-
-  def this(messages: MessageSet) = this(ErrorMapping.NoError, -1L, messages)
-  
 }
 
 // SENDS

http://git-wip-us.apache.org/repos/asf/kafka/blob/cd81d37a/core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
----------------------------------------------------------------------
diff --git a/core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala b/core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
index bc415e3..8df0982 100644
--- a/core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
+++ b/core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
@@ -35,10 +35,10 @@ object SerializationTestUtils{
   private val isr1 = List(0, 1, 2)
   private val leader2 = 0
   private val isr2 = List(0, 2, 3)
-  private val partitionDataFetchResponse0 = new FetchResponsePartitionData(new ByteBufferMessageSet(new
Message("first message".getBytes)))
-  private val partitionDataFetchResponse1 = new FetchResponsePartitionData(new ByteBufferMessageSet(new
Message("second message".getBytes)))
-  private val partitionDataFetchResponse2 = new FetchResponsePartitionData(new ByteBufferMessageSet(new
Message("third message".getBytes)))
-  private val partitionDataFetchResponse3 = new FetchResponsePartitionData(new ByteBufferMessageSet(new
Message("fourth message".getBytes)))
+  private val partitionDataFetchResponse0 = new FetchResponsePartitionData(messages = new
ByteBufferMessageSet(new Message("first message".getBytes)))
+  private val partitionDataFetchResponse1 = new FetchResponsePartitionData(messages = new
ByteBufferMessageSet(new Message("second message".getBytes)))
+  private val partitionDataFetchResponse2 = new FetchResponsePartitionData(messages = new
ByteBufferMessageSet(new Message("third message".getBytes)))
+  private val partitionDataFetchResponse3 = new FetchResponsePartitionData(messages = new
ByteBufferMessageSet(new Message("fourth message".getBytes)))
   private val partitionDataFetchResponseMap = Map((0, partitionDataFetchResponse0), (1, partitionDataFetchResponse1),
(2, partitionDataFetchResponse2), (3, partitionDataFetchResponse3))
 
   private val topicDataFetchResponse = {


Mime
View raw message