Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4CA71200C74 for ; Sun, 14 May 2017 15:28:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4B2E0160BA9; Sun, 14 May 2017 13:28:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6C1F0160BA6 for ; Sun, 14 May 2017 15:28:10 +0200 (CEST) Received: (qmail 6614 invoked by uid 500); 14 May 2017 13:28:09 -0000 Mailing-List: contact dev-help@jspwiki.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jspwiki.apache.org Delivered-To: mailing list dev@jspwiki.apache.org Received: (qmail 6603 invoked by uid 99); 14 May 2017 13:28:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 May 2017 13:28:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 21B00C00A9 for ; Sun, 14 May 2017 13:28:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id qycQn_shr2Tx for ; Sun, 14 May 2017 13:28:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 803C55F343 for ; Sun, 14 May 2017 13:28:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8D322E01A8 for ; Sun, 14 May 2017 13:28:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DC82621DEB for ; Sun, 14 May 2017 13:28:04 +0000 (UTC) Date: Sun, 14 May 2017 13:28:04 +0000 (UTC) From: "Harry Metske (JIRA)" To: dev@jspwiki.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (JSPWIKI-1059) ConcurrentModificationException in SessionMonitor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 14 May 2017 13:28:11 -0000 [ https://issues.apache.org/jira/browse/JSPWIKI-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harry Metske updated JSPWIKI-1059: ---------------------------------- Attachment: JSPWIKI-1059.patch Make iterating the sessions synchronized. > ConcurrentModificationException in SessionMonitor > ------------------------------------------------- > > Key: JSPWIKI-1059 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1059 > Project: JSPWiki > Issue Type: Bug > Components: Authentication & Authorization > Affects Versions: 2.10.2 > Environment: Ubuntu 16.04 > Java 8 > JSPWiki v2.10.3-git-38 > Reporter: Harry Metske > Assignee: Harry Metske > Priority: Minor > Fix For: 2.10.3 > > Attachments: JSPWIKI-1059.patch > > > jspwiki.log shows regularly: > 2017-05-10 12:35:55,838 INFO plugin.DefaultPluginManager - Plugin failed while executing: > java.util.ConcurrentModificationException > at java.util.WeakHashMap$HashIterator.nextEntry(WeakHashMap.java:806) > at java.util.WeakHashMap$ValueIterator.next(WeakHashMap.java:833) > at org.apache.wiki.auth.SessionMonitor.userPrincipals(SessionMonitor.java:204) > at org.apache.wiki.auth.SessionMonitor.sessions(SessionMonitor.java:185) > at org.apache.wiki.WikiSession.sessions(WikiSession.java:808) > at org.apache.wiki.plugin.SessionsPlugin.execute(SessionsPlugin.java:115) > at org.apache.wiki.plugin.DefaultPluginManager.execute(DefaultPluginManager.java:339) > at org.apache.wiki.parser.PluginContent.getText(PluginContent.java:194) > at org.jdom2.output.support.AbstractXMLOutputProcessor.printText(AbstractXMLOutputProcessor.java:771) > at org.jdom2.output.support.AbstractXMLOutputProcessor.printContent(AbstractXMLOutputProcessor.java:956) > at org.jdom2.output.support.AbstractXMLOutputProcessor.printElement(AbstractXMLOutputProcessor.java:868) > at org.jdom2.output.support.AbstractXMLOutputProcessor.printContent(AbstractXMLOutputProcessor.java:946) > at org.jdom2.output.support.AbstractXMLOutputProcessor.printElement(AbstractXMLOutputProcessor.java:868) > at org.jdom2.output.support.AbstractXMLOutputProcessor.printContent(AbstractXMLOutputProcessor.java:946) > at org.jdom2.output.support.AbstractXMLOutputProcessor.printElement(AbstractXMLOutputProcessor.java:868) > at org.jdom2.output.support.AbstractXMLOutputProcessor.printContent(AbstractXMLOutputProcessor.java:946) > at org.jdom2.output.support.AbstractXMLOutputProcessor.process(AbstractXMLOutputProcessor.java:236) > at org.jdom2.output.XMLOutputter.outputElementContent(XMLOutputter.java:881) > at org.apache.wiki.render.XHTMLRenderer.getString(XHTMLRenderer.java:71) > at org.apache.wiki.render.RenderingManager.getHTML(RenderingManager.java:241) > at org.apache.wiki.render.RenderingManager.getHTML(RenderingManager.java:286) > at org.apache.wiki.WikiEngine.textToHTML(WikiEngine.java:1515) > at org.apache.wiki.WikiEngine.getHTML(WikiEngine.java:1457) > at org.apache.wiki.tags.InsertPageTag.doWikiStartTag(InsertPageTag.java:128) > at org.apache.wiki.tags.WikiTagBase.doStartTag(WikiTagBase.java:89) > at org.apache.jsp.templates.haddock.Header_jsp._jspx_meth_wiki_005fInsertPage_005f1(Header_jsp.java:644) > at org.apache.jsp.templates.haddock.Header_jsp._jspx_meth_wiki_005fPageExists_005f0(Header_jsp.java:602) > at org.apache.jsp.templates.haddock.Header_jsp._jspService(Header_jsp.java:251) > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:742) > at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:443) > at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:385) > at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:329) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:742) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) > at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:710) > at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:580) > at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:516) > at org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:895) > at org.apache.jasper.runtime.PageContextImpl.include(PageContextImpl.java:490) > at org.apache.wiki.tags.IncludeTag.doEndTag(IncludeTag.java:84) > at org.apache.jsp.templates.haddock.ViewTemplate_jsp._jspx_meth_wiki_005fInclude_005f1(ViewTemplate_jsp.java:691) > at org.apache.jsp.templates.haddock.ViewTemplate_jsp._jspService(ViewTemplate_jsp.java:211) > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:742) > at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:443) > at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:385) > at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:329) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:742) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) > at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:710) > at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:580) > at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:516) > at org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:895) > at org.apache.jasper.runtime.PageContextImpl.include(PageContextImpl.java:490) > at org.apache.wiki.tags.IncludeTag.doEndTag(IncludeTag.java:84) > at org.apache.jsp.Wiki_jsp._jspService(Wiki_jsp.java:182) > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:742) > at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:443) > at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:385) > at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:329) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:742) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) > at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) > at org.apache.wiki.ui.WikiServletFilter.doFilter(WikiServletFilter.java:160) > I will attach a proposed patch -- This message was sent by Atlassian JIRA (v6.3.15#6346)