Return-Path: X-Original-To: apmail-jspwiki-dev-archive@www.apache.org Delivered-To: apmail-jspwiki-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A093611525 for ; Wed, 27 Aug 2014 23:56:58 +0000 (UTC) Received: (qmail 30124 invoked by uid 500); 27 Aug 2014 23:56:58 -0000 Delivered-To: apmail-jspwiki-dev-archive@jspwiki.apache.org Received: (qmail 30089 invoked by uid 500); 27 Aug 2014 23:56:58 -0000 Mailing-List: contact dev-help@jspwiki.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jspwiki.apache.org Delivered-To: mailing list dev@jspwiki.apache.org Received: (qmail 30076 invoked by uid 99); 27 Aug 2014 23:56:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Aug 2014 23:56:58 +0000 Date: Wed, 27 Aug 2014 23:56:58 +0000 (UTC) From: "David Vittor (JIRA)" To: dev@jspwiki.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (JSPWIKI-856) Enhance FileSystemProvider to be able to save page attributes as properties MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JSPWIKI-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113088#comment-14113088 ] David Vittor commented on JSPWIKI-856: -------------------------------------- Thanks Harry, Hmm, yes I've very curious to see how the PageViewPlugin works. I think it's using event based actions, i.e. EventListener on the pages. I'll check this out also, as the model here might be better suited, even for my above mentioned use cases. The ability to save custom attributes is still useful, but only on the event of a page save, which isn't always the right timing. I'll have a look at writing some test cases, but will do this after I finish some uni assignments. Thanks. > Enhance FileSystemProvider to be able to save page attributes as properties > --------------------------------------------------------------------------- > > Key: JSPWIKI-856 > URL: https://issues.apache.org/jira/browse/JSPWIKI-856 > Project: JSPWiki > Issue Type: New Feature > Components: Core & storage > Affects Versions: 2.10.1 > Reporter: David Vittor > Labels: provider > Attachments: AbstractFileProvider.java, AbstractFileProvider.java, FileSystemProvider.java, FileSystemProvider.java, VersioningFileProvider.java, VersioningFileProvider.java, WikiPage.java, providers.patch, providers.patch > > > *Requirements:* > * 1. Plugins and other code should be able to store some page "attributes" into the "properties" of a page, just as author and changenote currently are. > * 2. This should work for both FileSystemProvider and VersioningFileProvider and any future JDBCProviders or EncryptionProviders > * 3. The properties added should be dynamic, e.g. all properties starting with "db:" like "db:likes", or "db:hitcount" > ** 3.1. A "protected" addCustomProperties() method should be done added > * 4. The property names and property values should be validated > ** 4.1. A "protected" validateCustomProperties() method should be done added > ** 4.2 e.g. only contain ascii characters > ** 4.3 Max property key length > ** 4.4 Max property value length > ** 4.5 Max number of properties -- This message was sent by Atlassian JIRA (v6.2#6252)