Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Message-ID: <423810309.1203253834555.JavaMail.jira@brutus>
Date: Sun, 17 Feb 2008 05:10:34 -0800 (PST)
From: "Janne Jalkanen (JIRA)" <jira@apache.org>
To: jspwiki-dev@incubator.apache.org
Subject: [jira] Commented: (JSPWIKI-188) improving usability regarding usage
 of JNDI or custom mail
In-Reply-To: <1139588450.1203243394577.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JSPWIKI-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569695#action_12569695 ] 

Janne Jalkanen commented on JSPWIKI-188:
----------------------------------------

Ok, looks way better now.

However, please try to send a single patch only without zipping it up.  If you zip it it means that we have to go through a number of extra steps to see what the patch contains, and in this case, it even comes in multiple files (even though they could easily be a part of the same patch).  This all makes it harder to review.

Also, if your patch contains such independent functionalities that it needs to go into two patches, then there should really be two JIRA issues as well.

> improving usability regarding usage of JNDI or custom mail
> ----------------------------------------------------------
>
>                 Key: JSPWIKI-188
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-188
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.6.1
>            Reporter: Florian Holeczek
>            Priority: Minor
>         Attachments: JSPWIKI-188_patch.zip
>
>
> This issue is part one of the divided JSPWIKI-187.
> At the moment, if there are any errors or misconfigurations with mail, the user simply won't be able to find anything useful in the logs.
> This patch improves the information flow to the standard user (log level info) as well as the administrator (log level debug) in MailUtil.
> The patch for jspwiki.properties.tmpl should make mail configuration clearer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.