From issues-return-13969-archive-asf-public=cust-asf.ponee.io@jmeter.apache.org Sat Jan 5 13:27:13 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C3953180645 for ; Sat, 5 Jan 2019 13:27:12 +0100 (CET) Received: (qmail 41701 invoked by uid 500); 5 Jan 2019 12:27:11 -0000 Mailing-List: contact issues-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@jmeter.apache.org Delivered-To: mailing list issues@jmeter.apache.org Received: (qmail 41689 invoked by uid 99); 5 Jan 2019 12:27:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Jan 2019 12:27:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 34C3DC25E6 for ; Sat, 5 Jan 2019 12:27:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -10.301 X-Spam-Level: X-Spam-Status: No, score=-10.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id CZi7gD_xvasq for ; Sat, 5 Jan 2019 12:27:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EF3AF5FAC6 for ; Sat, 5 Jan 2019 12:27:09 +0000 (UTC) Received: from asf-bz1-us-mid.priv.apache.org (nat1-us-mid.apache.org [23.253.172.122]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTPS id 24865E02ED for ; Sat, 5 Jan 2019 12:27:09 +0000 (UTC) Received: by asf-bz1-us-mid.priv.apache.org (ASF Mail Server at asf-bz1-us-mid.priv.apache.org, from userid 33) id 18C36608B1; Sat, 5 Jan 2019 12:27:07 +0000 (UTC) From: bugzilla@apache.org To: issues@jmeter.apache.org Subject: [Bug 63025] Search and replace not working for port number Date: Sat, 05 Jan 2019 12:27:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: JMeter X-Bugzilla-Component: HTTP X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: FixedInTrunk X-Bugzilla-Severity: minor X-Bugzilla-Who: felix.schumacher@internetallee.de X-Bugzilla-Status: NEEDINFO X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: issues@jmeter.apache.org X-Bugzilla-Target-Milestone: JMETER_5.1 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bz.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 https://bz.apache.org/bugzilla/show_bug.cgi?id=3D63025 --- Comment #12 from Felix Schumacher -= -- (In reply to Philippe Mouawad from comment #10) > (In reply to Felix Schumacher from comment #8) > > (In reply to Philippe Mouawad from comment #6) > > > (In reply to Felix Schumacher from comment #5) > > > > Created attachment 36360 [details] > > > > Replace port and protocol in HTTP Samplers > > > >=20 > > > > This is basically the diff from the originally attached source. It = has been > > > > refactored to eliminate duplicate code. That should make it easy to= add more > > > > parameters to be replaced, like the proxy parameters. > > >=20 > > > Hello,=20 > > > Thanks for patch. > > > Look good to me except that if I understand correctly, it would not be > > > possible to replace port by ${portNumber} due to this: > > >=20 > > > (s) -> setPort(Integer.parseInt(s) > >=20 > > That has to be done, as setPort accepts int, only. The expression is > > probably set on the ui element and not on the sampler. > >=20 > >=20 > > >=20 > > > Regards >=20 > Hi Felix, > I think we can safely introduce this setPort(String value) method. > When we read it, it's read as StringProperty. I opted to change the property directly. That makes it really easy to add m= ore properties if we want to change them as well. I wonder if we should use that path for the already implemented getDomain a= nd getPath as getPath changes the property value by encoding spaces. >=20 > I don't want to commit your work as you should be the committer (I don't > want to have credit for your work :-) ), so if you can commit this code, I > can add it later or you can also do it if you want. No problem, I would not have been angry with you. >=20 > Thanks --=20 You are receiving this mail because: You are the assignee for the bug.=