jmeter-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 63025] Search and replace not working for port number
Date Sat, 05 Jan 2019 12:27:07 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=63025

--- Comment #12 from Felix Schumacher <felix.schumacher@internetallee.de> ---
(In reply to Philippe Mouawad from comment #10)
> (In reply to Felix Schumacher from comment #8)
> > (In reply to Philippe Mouawad from comment #6)
> > > (In reply to Felix Schumacher from comment #5)
> > > > Created attachment 36360 [details]
> > > > Replace port and protocol in HTTP Samplers
> > > > 
> > > > This is basically the diff from the originally attached source. It has
been
> > > > refactored to eliminate duplicate code. That should make it easy to add
more
> > > > parameters to be replaced, like the proxy parameters.
> > > 
> > > Hello, 
> > > Thanks for patch.
> > > Look good to me except that if I understand correctly, it would not be
> > > possible to replace port by ${portNumber} due to this:
> > > 
> > > (s) -> setPort(Integer.parseInt(s)
> > 
> > That has to be done, as setPort accepts int, only. The expression is
> > probably set on the ui element and not on the sampler.
> > 
> > 
> > > 
> > > Regards
> 
> Hi Felix,
> I think we can safely introduce this setPort(String value) method.
> When we read it, it's read as StringProperty.

I opted to change the property directly. That makes it really easy to add more
properties if we want to change them as well.

I wonder if we should use that path for the already implemented getDomain and
getPath as getPath changes the property value by encoding spaces.

> 
> I don't want to commit your work as you should be the committer (I don't
> want to have credit for your work :-) ), so if you can commit this code, I
> can add it later or you can also do it if you want.

No problem, I would not have been angry with you.

> 
> Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
Mime
View raw message