jmeter-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 63025] Search and replace not working for port number
Date Wed, 02 Jan 2019 19:03:18 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=63025

--- Comment #9 from Felix Schumacher <felix.schumacher@internetallee.de> ---
(In reply to Mohamed Ibrahim from comment #7)
> Hello all,
> 
> This is my first try in contribution to open source.
> I just followed the steps given in the following apache page
> https://jmeter.apache.org/building.html

And you did great.

> 
> 
> 
> I did exactly whatever has been given in the instructions. But, I don't know
> how it was not updated in the trunk.

JMeter's trunk can only be updated by Committers. See
https://www.apache.org/foundation/getinvolved.html for more on this.

I suspect, you followed the "Create a PR using GIT" instruction on the building
page. There is one last step there, that you missed. It is the creation of the
pull request. That way we would have been notified of your changes.

For more information and or further discussion about contributing, I suggest
that you subscribe to the users (or developers) mailing list and send your
questions/suggestions there.


> 
> You can still check my forked repo in github.
> 
> https://github.com/rollno748/jmeter/blob/63025/src/protocol/http/org/apache/
> jmeter/protocol/http/sampler/HTTPSamplerProxy.java
> 
> 
> I was trying my best to do it to push the code.

And thanks again for trying.

> 
> Please let me know where i went wrong and Is there any proper documentation
> available code committing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
Mime
View raw message