jmeter-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 62887] Customized SampleLabel is ignored and overwritten by JMeter 5.0
Date Thu, 08 Nov 2018 21:23:17 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887

--- Comment #8 from Philippe Mouawad <p.mouawad@ubik-ingenierie.com> ---
(In reply to Artem Fedorov from comment #7)
> Hi all,
> 
> I agree with attached fix, but it can throw NPE, because it skip check for
> null
> 
> 
> if(subResult == null) {
>   // see https://bz.apache.org/bugzilla/show_bug.cgi?id=54778
>   return;
> }
> 
> The other suggestion is add jmeter.property for enable/disable subResults
> rename option.

Hello Artem,

1/ IMO, having a property that can break report is a bit weird no ? And it's
another option for a requirement that is a edgy.


2/ Regarding the patch , I don't understand why addSubResult is called twice.
Am I missing something ? Should the second addSubResults be in an else ?

Same issue for other methods unless I am wrong.

3/ Also wouldn't this patch  have an impact on JMeter performances by adding a
String comparison for every Sub result addition .

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
Mime
View raw message