jmeter-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 62887] Customized SampleLabel is ignored and overwritten by JMeter 5.0
Date Wed, 14 Nov 2018 21:19:23 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887

--- Comment #16 from Alan Silva <alansq16@hotmail.com> ---
(In reply to Philippe Mouawad from comment #10)
> (In reply to Alan Silva from comment #9)
> > Oh yes. You're absolutely right @Philippe Mouawad.
> > 
> > The patch should haven been an if/else. My mistake.
> > 
> > In any case, as I said in my previous comment:
> > 
> > Calling addSubResult(SampleResult subResult, false) is good enough I think.
> > 
> > That's what I ended up doing and I would presume that it's what other Jmeter
> > users that upgraded to 5.0 and use custom result labels did as well.
> 
> Hello Alan,
> Thanks for your feedback.
> 
> So In your opinion, is it ok to do nothing ? or should we do something.
> 
> Of course we should add a note on this in release notes.
> 
> Thanks

Hi, sorry I stopped monitoring this ticket for a bit.

IMO, you could leave the current implementation as is, as long as it's
mentioned in the rel notes like you suggested.

As long as other users like myself don't have to open up the code to find out
why things changed, then I think everything is good.

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.
Mime
View raw message