jmeter-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 61901] Support for https.cipherSuites property
Date Wed, 13 Dec 2017 20:50:16 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=61901

--- Comment #3 from Philippe Mouawad <p.mouawad@ubik-ingenierie.com> ---
(In reply to Jeremy Arnold from comment #2)
> I apologize for the confusion between System property vs JMeter property.  I
> intended for this to be a System property (set in system.properties) to
> match the behavior of HttpsURLConnection / HttpClient.  But when I wrote the
> patch I was following the example of https.socket.protocols, and thus used
> JMeterUtils.getPropDefault.

Ok
> 
> Since JMeterUtils.loadJMeterProperties initializes its local properties
> using "Properties p = new Properties(System.getProperties())", I believe the
> code does work with System properties in addition to JMeter properties.  (In
> my testing, I set the value in the system.properties file.)

You are right.

> 
> I'd be happy to update the patch to use System.getProperty instead so this
> value can only be set as a System property and not a JMeter property. 
> Please let me know if that's your preference.

It looks fine.
For your information if you submit future patches, documentation is in xdocs,
docs html are generated from there.
> 
> 
> I haven't gotten completely to the bottom of the performance issue.  In my
> test the JMeter system CPU was maxed out, primarily performing SSL
> handshakes.  I wouldn't expect quite as big of a difference in CPU
> utilization between the two cipher suites that were being used.  My
> suspicion was that one of them was being hardware accelerated and the other
> not, but I have not yet confirmed that.


Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
Mime
View raw message