jmeter-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 61724] Add __sha1 and __sha256 functions
Date Sun, 05 Nov 2017 14:01:37 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=61724

Philippe Mouawad <p.mouawad@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #3 from Philippe Mouawad <p.mouawad@ubik-ingenierie.com> ---
Thank you for your contribution, I have few remarks:

- Why salt is not also there for SHA1 ?
- I think 1 more generic function is enough
- It would be better to have something like __digest(algorithm, string to
digest, salt (optional),uppercase (optional defaults to false), varName
(optional)). This would allow more generic algorithm addition
- synchronized does not seem to be needed for me

-- 
You are receiving this mail because:
You are the assignee for the bug.
Mime
View raw message