jmeter-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53957] HTTP Request : In Parameters tab, when pasting lists from the clipboard, parse on ':' instead of tab.
Date Fri, 03 Nov 2017 09:30:48 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=53957

Philippe Mouawad <p.mouawad@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When pasting lists from the |HTTP Request : In
                   |clipboard, parse on ':'     |Parameters tab, when
                   |instead of tab.             |pasting lists from the
                   |                            |clipboard, parse on ':'
                   |                            |instead of tab.
             Status|NEW                         |NEEDINFO

--- Comment #11 from Philippe Mouawad <p.mouawad@ubik-ingenierie.com> ---
Thanks for patch.
See my notes below.
(In reply to Andrew Burton from comment #9)
> Created attachment 35479 [details]
> HTTP arguments delimiter
> 
> Wouldn't the biggest use-case for copying-pasting HTTP arguments be from a
> Chrome or Firefox dev tab? In that case, we could easily make the case that
> the default argument separator would be ':' and line separator would be '&'.


In your code you didn't use colon but equal , why :
private static final String CLIPBOARD_ARG_DELIMITERS = "\t|="; //$NON-NLS-1$

So this does not pastes correctly "parsed parameters" from Chrome

But replacing it with :
private static final String CLIPBOARD_ARG_DELIMITERS = "\t|=|:"; //$NON-NLS-1$

Can lead to wrong pasting when value is an url that contains ':'

> 
> If copying/pasting from other arguments, which would take '\t' and '\n' as
> the separators, that could be a separate check.
> 
> I've attached a patch (also posted to the JMeter Dev mailing list) that
> applies this to HTTPArgumentsPanel.java
> 
> This bug has been open for 5 years now and it's one of my biggest bug-bears
> about copying query parameters into the HTTP Arguments panel.
> 
> We also have separate classes for the HeaderArguments panel and generic
> Arguments panel, so any specific delimiter could be applied there, rather
> than making a delimiter in the already comprehensive set of config
> parameters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
Mime
View raw message