Mailing-List: contact issues-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@jmeter.apache.org
MIME-Version: 1.0
References: <bug-60687-58895@https.bz.apache.org/bugzilla/>
 <bug-60687-58895-J08Wkv2foP@https.bz.apache.org/bugzilla/>
 <CAB=Je-HoMxPU0qzR+YsRcjytenE-FUZkWpCzd9MaXs_2=RqeqA@mail.gmail.com>
 <AF3B7D31-E395-4A02-8E9B-343DD20264FB@internetallee.de> <CAH9fUpYqPJY34MbP+h9fr4CDxjGhbzzgW_=ExHeGP7Cz-yN_-Q@mail.gmail.com>
In-Reply-To: <CAH9fUpYqPJY34MbP+h9fr4CDxjGhbzzgW_=ExHeGP7Cz-yN_-Q@mail.gmail.com>
From: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
Date: Sat, 04 Feb 2017 14:52:42 +0000
Message-ID: <CAB=Je-HhULMsk42wvWKQE_SYrO5RT=HguQrE8xsdi7JQu2Fcdg@mail.gmail.com>
Subject: Re: [Bug 60687] Make GUI more responsive when LoggerPanel gets a lot
 of events
To: issues@jmeter.apache.org
Content-Type: multipart/alternative; boundary=94eb2c14c67e908f3a0547b58df9
archived-at: Sat, 04 Feb 2017 14:53:04 -0000

--94eb2c14c67e908f3a0547b58df9
Content-Type: text/plain; charset=UTF-8

Felix> The timer lives in the awt thread, so we need no invokeLater. Or do
I miss
Felix> something?

I thought it was java.util.Timer.
I did not notice that was javax.swing.Timer. swing timer is fine.

Philippe>I agree. The only reason I would see for calling invokeLater would
maybe to
Philippe>avoid freezing UI if the call takes more than some limit

invokeLater is not required provided the timer is swing timer.

I wonder if we can rework log panel into "append" calls instead of "set
text from scratch".

Philippe>For me there is only 1 Timer thread no ?

I'm not sure if we can reuse that swing timer to aggregate events form
listeners (e.g. statistics listeners, etc).

Felix>The component is set to an empty text

Oh, I did not notice that. On the other hand, it looks awkward.
I find "buffer.clear(); modified=true;" easier to reason about since that
results in a single place where the textarea gets updated.


PS. Are you sure "events.clear()" is thread-safe?

PPS. Can we move format.format(logEvent) out of syncrhonized(events) block?

Vladimir

--94eb2c14c67e908f3a0547b58df9--