jmeter-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: [Bug 60687] Make GUI more responsive when LoggerPanel gets a lot of events
Date Sat, 04 Feb 2017 14:18:32 GMT
On Sat, Feb 4, 2017 at 3:06 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
>
> Am 4. Februar 2017 14:02:58 MEZ schrieb Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com>:
> >It does not look good to me.
> >I think
> >1) SwingUtilities.invokeLater is missing
>
> The timer lives in the awt thread, so we need no invokeLater. Or do I miss
> something?
>
I agree. The only reason I would see for calling invokeLater would maybe to
avoid freezing UI if the call takes more than some limit.

>
> >2) .clear() misses to set logChanged=true
>
> The component is set to an empty text, so logChanged can be left alone, or
> even set to false. Don't you think?
>
> >3) if (logChanged) should be expressed as if (!logChanged) {return;}
>
> Probably.
>
> >4) Do we really need a thread there? How that approach would scale
> >across
> >new components (e.g. statistics, etc, etc)?
>
> You mean the timer thread?
>
I think so but I don't understand the comment. For me there is only 1 Timer
thread no ?

>
> Felix
>
> >
> >Vladimir
>



-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message