Mailing-List: contact issues-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@jmeter.apache.org
From: bugzilla@apache.org
To: issues@jmeter.apache.org
Subject: [Bug 60589] Migrating LogKit to SLF4J - Drop avalon, logkit and
 excalibur with backward compatibility for 3rd party modules.
Date: Fri, 20 Jan 2017 06:14:28 +0000
Message-ID: <bug-60589-58895-WO3LXzx2fk@https.bz.apache.org/bugzilla/>
In-Reply-To: <bug-60589-58895@https.bz.apache.org/bugzilla/>
References: <bug-60589-58895@https.bz.apache.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Auto-Submitted: auto-generated
MIME-Version: 1.0
archived-at: Fri, 20 Jan 2017 06:14:44 -0000

https://bz.apache.org/bugzilla/show_bug.cgi?id=3D60589

--- Comment #4 from Woonsan Ko <woonsan@apache.org> ---
I've created an initial pull request. This is not ready for merging, but on=
ly
for initial review on the direction:
- https://github.com/apache/jmeter/pull/254

This PR contains only the following at the moment:
- Removing dependencies on logkit, excalibur and avalon.
- Forking some logkit classes in jorphan.
- NewDriver.java setting log4j2 configuration file location system property.
- Add jcl-over-slf4j, log4j-1.2-api, jcl-over-slf4j and log4j2 jars.
- Update LoggingManager to return slf4j logger wrapper.

It doesn't include a custom appender for the UI and unit test fixes yet. Al=
so
requires cleanups.

But it seems working at runtime with log4j2 now in this steps:
$ git clone -b feature/bz60589-1 https://github.com/woonsan/jmeter.git
$ cd jmeter
$ ant download_jars
$ ant
$ cd bin
$ ./jmeter
Now, I see jmeter.log being added by log4j2 via logkit fork Logger (wrapping
slf4j logger) / LoggingManager.

Please review the PR and share your thoughts on the direction.

P.S. The original logkit Logger is a class (not an interface) with final
methods. So, I decided to remove the final modifier and add abstract modifi=
er
for overridable methods (for wrapper impl). And I kept unsupportable method=
s as
NOP impl.

--=20
You are receiving this mail because:
You are the assignee for the bug.=