jmeter-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 60589] Migrating LogKit to SLF4J - Drop avalon, logkit and excalibur with backward compatibility for 3rd party modules.
Date Sat, 21 Jan 2017 08:11:19 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60589

--- Comment #5 from Philippe Mouawad <p.mouawad@ubik-ingenierie.com> ---
(In reply to Woonsan Ko from comment #4)
> I've created an initial pull request. This is not ready for merging, but
> only for initial review on the direction:
> - https://github.com/apache/jmeter/pull/254
> 
> This PR contains only the following at the moment:
> - Removing dependencies on logkit, excalibur and avalon.
> - Forking some logkit classes in jorphan.
> - NewDriver.java setting log4j2 configuration file location system property.
> - Add jcl-over-slf4j, log4j-1.2-api, jcl-over-slf4j and log4j2 jars.
> - Update LoggingManager to return slf4j logger wrapper.
> 
> It doesn't include a custom appender for the UI and unit test fixes yet.
> Also requires cleanups.
> 
> But it seems working at runtime with log4j2 now in this steps:
> $ git clone -b feature/bz60589-1 https://github.com/woonsan/jmeter.git
> $ cd jmeter
> $ ant download_jars
> $ ant
> $ cd bin
> $ ./jmeter
> Now, I see jmeter.log being added by log4j2 via logkit fork Logger (wrapping
> slf4j logger) / LoggingManager.
> 
> Please review the PR and share your thoughts on the direction.
> 
> P.S. The original logkit Logger is a class (not an interface) with final
> methods. So, I decided to remove the final modifier and add abstract
> modifier for overridable methods (for wrapper impl). And I kept
> unsupportable methods as NOP impl.

The direction looks good to me.
Thanks for your work.

I suppose last step is having:
- custom appender for the UI 
- The ability to set debug level through the menu
- Fix Test Units

Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.
Mime
View raw message