From dev-return-15459-archive-asf-public=cust-asf.ponee.io@jmeter.apache.org Sun Jan 10 04:24:11 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 05EE4180626 for ; Sun, 10 Jan 2021 05:24:11 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 41E53456CE for ; Sun, 10 Jan 2021 04:24:10 +0000 (UTC) Received: (qmail 76643 invoked by uid 500); 10 Jan 2021 04:24:09 -0000 Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list dev@jmeter.apache.org Received: (qmail 76620 invoked by uid 99); 10 Jan 2021 04:24:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jan 2021 04:24:08 +0000 From: =?utf-8?q?GitBox?= To: dev@jmeter.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bjmeter=5D_ham1_commented_on_a_change_in_pull_reque?= =?utf-8?q?st_=23638=3A_Bolt_Sampler_-_Neo4j_4=2Ex_and_cluster_features?= Message-ID: <161025264869.15632.3602931395768235190.asfpy@gitbox.apache.org> Date: Sun, 10 Jan 2021 04:24:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: ham1 commented on a change in pull request #638: URL: https://github.com/apache/jmeter/pull/638#discussion_r554373945 ########## File path: src/protocol/bolt/src/main/java/org/apache/jmeter/protocol/bolt/sampler/AbstractBoltTestElement.java ########## @@ -17,13 +17,53 @@ package org.apache.jmeter.protocol.bolt.sampler; +import java.time.Duration; + +import org.apache.commons.lang3.EnumUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.jmeter.testelement.AbstractTestElement; +import org.neo4j.driver.AccessMode; +import org.neo4j.driver.SessionConfig; +import org.neo4j.driver.TransactionConfig; public abstract class AbstractBoltTestElement extends AbstractTestElement { private String cypher; private String params; + private String database; + private String accessMode; private boolean recordQueryResults; + private int txTimeout; + + public int getTxTimeout() { + return txTimeout; + } + + public void setTxTimeout(int txTimeout) { + this.txTimeout = txTimeout; + } + + public String getAccessMode() { + if (accessMode != null) { Review comment: Consider writing this using a guard clause? i.e. ``` if (accessMode == null) { return AccessMode.WRITE.toString(); } return accessMode; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org