jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vincent Daburon <vdabu...@gmail.com>
Subject Re: [VOTE] Release JMeter 5.4 RC1
Date Thu, 26 Nov 2020 16:14:05 GMT
Hi,
I open a pull request for image ratio modifications
https://github.com/apache/jmeter/pull/635

In the documentation, http request, the image don’t have correct ratio format
img src="../../docs/images/screenshots/http-request-advanced-tab.png"
width="951" height="284"
The full image size is
1113px × 642px  => 1113/642=1,73364486

The same ratio format is
951/548
So change the height="284" to height="548"

Images ratios changed
src="../../docs/images/screenshots/http-request-advanced-tab.png"
width="951" height="548"
src="../../docs/images/screenshots/csvdatasetconfig.png" width="658"
height="281"
src="../../docs/images/screenshots/threadgroup.png" width="911" height="662 »
src="../../docs/images/screenshots/curl/enter_command.png" width="767"
height="443"
src="../../docs/images/screenshots/curl/enter_command_from_file.png"
width="767" height="449"
src="../../docs/images/screenshots/curl/result.png" width="767" height="464"
src="../../docs/images/screenshots/curl/http_request_warning.png"
width="768" height="464"

Regards.

Vincent DABURON


Le jeu. 26 nov. 2020 à 01:49, Graham Russell <graham@ham1.co.uk> a écrit :
>
> A small thing from me, I noticed that the Raw InfluxDB Backend
> Listener (https://github.com/apache/jmeter/pull/544) wasn't mentioned
> in the change log.
> Could someone add it before the RC2?
>
> Thanks!
>
> Graham
>
> On Wed, 25 Nov 2020 at 17:46, Milamber <milamber@apache.org> wrote:
> >
> > Hello,
> >
> > Please ping me when I can start the RC2.
> >
> > Milamber
> >
> > On 11/25/20 4:59 PM, Felix Schumacher wrote:
> > > Am 24.11.20 um 22:58 schrieb Vladimir Sitnikov:
> > >> I wonder why all those plugins depend on LoggingManager.
> > > I think that is a lot of historical baggage. The plugins from
> > > jmeter-plugins repository are all cleaned up and will be released
> > > sometime in the future.
> > >
> > >> Given the number of usages, we would have to keep the class forever, so
we
> > >> might want to add the related javadoc.
> > > We can keep them, should we still mark those as deprecated?
> > >> If the third-party plugins use the class for logging purposes, then we
> > >> might even want to heal the class (e.g. divert all the logging calls to
the
> > >> current slf4j)
> > > I think the healing will depend on the jars that the
> > > plugin/plugin-manager brings to the table. If it uses our implementation
> > > of LoggingManager it will get a LogKit-adapter that delegates all log
> > > messages to SLF4J, does'nt it?
> > >> It is sad I did not check the usages outside of JMeter :-(
> > > No problem, I am happy, that we found this before we released a new version.
> > >
> > > Felix
> > >
> > >> Vladimir
> > >>
> >

Mime
View raw message