jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] pmouawad commented on pull request #499: AutoCorrelation: Add initial support
Date Sat, 14 Nov 2020 18:50:30 GMT

pmouawad commented on pull request #499:
URL: https://github.com/apache/jmeter/pull/499#issuecomment-727249831


   Hello,
   Thanks for last modifications.
   I tested the PR and saw the following problems:
   
   - Issue in the way recorder are placed: as you know recorder creates the HTTP Request with
"Follow Redirects checked" and when recording , in case of redirect, JMeter creates 2 HTTP
Requests (at least), the first one (enabled) with the request, the second one (disabled) as
the result of redirect. But it seems you add the extractors to the disabled request instead
of adding them to the first one. This issue is a blocker for me
   - Naming of variables: with the docker command I gave you, it seems you create variables
named "challenger[step_id](2)", I  think you should apply some "cleanup" on variable names
(replace special characters)
   - I don't understand the logic for choosing extractors, for example why sometimes for extracting
value of input, you select Regex and not CSS selector ? 
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message