jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <>
Subject [GitHub] jmeter pull request #387: Add delegation for SPNEGO back to JMeter
Date Thu, 07 Jun 2018 18:01:27 GMT
GitHub user FSchumacher opened a pull request:

    Add delegation for SPNEGO back to JMeter

    ## Description
    <!--- Provide a general summary of your changes in the Title above -->
    <!--- Describe your changes in detail here -->
    Newer httpclient versions (at least in the 4.x branch) have dropped the support for delegation
of kerberos tickets over SPNEGO. This patch brings back the support to delegation back to
    ## Motivation and Context
    Older versions of JMeter always tried to get forwardable tickets when using SPNEGO. As
I need this functionality for a service, I would like to have the forwarding back. As the
default forwarding could be seen critical from a security standpoint, the patch disables it
by default. It can be enabled by a system property.
    <!--- Why is this change required? What problem does it solve? -->
    <!--- If it fixes an open issue, please link to the issue here. -->
    ## How Has This Been Tested?
    <!--- Please describe in detail how you tested your changes. -->
    <!--- Include details of your testing environment, tests ran to see how -->
    <!--- your change affects other areas of the code, etc. -->
    Tested it on a service that depends on delegation of tickets.
    ## Screenshots (if appropriate):
    ## Types of changes
    <!--- What types of changes does your code introduce? Delete as appropriate -->
    - Bug fix (non-breaking change which fixes an issue) (At least I see this as a regression)
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply.
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
    - [x] My code follows the [code style][style-guide] of this project.
    - [x] I have updated the documentation accordingly.

You can merge this pull request into a Git repository by running:

    $ git pull delegate-krb

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #387
commit 94b369b64f931b75564e4df47231754602639972
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-06-07T17:54:03Z

    Add delegation for SPNEGO back to JMeter



View raw message