From dev-return-11565-archive-asf-public=cust-asf.ponee.io@jmeter.apache.org Mon May 7 20:51:19 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 44B95180648 for ; Mon, 7 May 2018 20:51:19 +0200 (CEST) Received: (qmail 89483 invoked by uid 500); 7 May 2018 18:51:18 -0000 Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list dev@jmeter.apache.org Received: (qmail 89468 invoked by uid 99); 7 May 2018 18:51:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2018 18:51:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 55D491A2C33 for ; Mon, 7 May 2018 18:51:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.99 X-Spam-Level: X-Spam-Status: No, score=0.99 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id QoSHTSyXIXZJ for ; Mon, 7 May 2018 18:51:15 +0000 (UTC) Received: from internetallee.de (internetallee.de [81.169.162.220]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 33AC65F4E4 for ; Mon, 7 May 2018 18:51:15 +0000 (UTC) Received: from [192.168.178.20] (p54889857.dip0.t-ipconnect.de [84.136.152.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by internetallee.de (Postfix) with ESMTPSA id 6F937E23983 for ; Mon, 7 May 2018 20:51:07 +0200 (CEST) Subject: Re: BUG 61748 / Request compression To: dev@jmeter.apache.org References: From: Felix Schumacher Message-ID: <61c12527-0f7e-950d-874e-0310b5dca401@internetallee.de> Date: Mon, 7 May 2018 20:51:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Am 07.05.2018 um 18:59 schrieb Vladimir Sitnikov: > Antonio>Do you have an idea of the performance impact? > > I'm afraid, it is inevitable. One of the further enhancements is might be > sending pre-compressed *.gz files > >> Option 1 seems better for me > It looks so. As far as I know, request body compression is not specified in > the standard, so using JMeter-specific "header" to trigger the compression > might be the right thing to do. > > For instance: > X-JMeter-Content-Compression: gzip > > Later it could be improved to: > X-JMeter-Content-Compression: gzip; compression_level=1 vs > X-JMeter-Content-Compression: gzip; compression_level=9 > > If we use just `Content-Encoding` to trigger the behavior, then it would be > hard to evolve. +1 If we use Content-Encoding, we could break other scripts, that have already compressed their payload. > > That means "body compression" might deserve its own set of UI checkboxes, > however it looks like the case is rare (neither HTTP/1 nor HTTP2 specify > body compression), so we might be fine to keep that behind "trigger header" > to avoid UI clutter. Right, nothing stops us from adding the ui or preprocessor or other mechanism after we introduce the header trigger. Regards,  Felix > > Vladimir >