jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From undera <...@git.apache.org>
Subject [GitHub] jmeter pull request #378: Fix 43612
Date Tue, 20 Mar 2018 13:16:19 GMT
Github user undera commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/378#discussion_r175759441
  
    --- Diff: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
    @@ -1649,6 +1648,43 @@ else if(getSendParameterValuesAsPostBody()) {
                 }
                 StringEntity requestEntity = new StringEntity(entityBodyContent.toString(),
charset);
                 entity.setEntity(requestEntity);
    +        } else if (hasArguments()) {
    --- End diff --
    
    Is it possible to extract this long code piece into separate method? For better readability.


---

Mime
View raw message