jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: svn commit: r1820380 - in /jmeter/trunk: bin/jmeter bin/jmeter.bat xdocs/changes.xml
Date Sun, 07 Jan 2018 14:33:50 GMT
Am 07.01.2018 um 15:30 schrieb sebb:
> On 7 January 2018 at 14:14, Felix Schumacher
> <felix.schumacher@internetallee.de> wrote:
>> Am 06.01.2018 um 10:47 schrieb pmouawad@apache.org:
>>> Author: pmouawad
>>> Date: Sat Jan  6 09:47:30 2018
>>> New Revision: 1820380
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1820380&view=rev
>>> Log:
>>> Bug 61970 - JMeter now uses english as default locale to avoid missing
>>> translations in some locales make UI look weird
>>
>> I read your prior messages as if we already had switched to English as
>> default language.
>>
>> This change reminds me of another issue I have with the start scripts. I
>> don't think it is a good idea to hardcode user-changeable values in the
>> start scripts. The user will have to edit the script each time we ship a new
>> version.
>>
>> In tomcat we source in a env.sh (env.bat) from a known position in the
>> filesystem where the user can set her own values. Those will override the
>> default values from the start script.
>>
>> Values I would like to see set in such a env.bat would include
>>
>>   * JAVA_HOME/JRE_HOME
>>   * JMETER_OPTS
>>   * HEAP
>>   * JMETER_LANGUAGE
>>   * GC_ALGO
>>   * SYSTEM_PROPS
>>   * JVM_ARGS
>>
>> What do you think?
> Good idea, but please start a new thread for a new subject.
done.

>>   Felix
>>
>>
>>> Bugzilla Id: 61970
>>>
>>> Modified:
>>>       jmeter/trunk/bin/jmeter
>>>       jmeter/trunk/bin/jmeter.bat
>>>       jmeter/trunk/xdocs/changes.xml
>>>
>>> Modified: jmeter/trunk/bin/jmeter
>>> URL:
>>> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter?rev=1820380&r1=1820379&r2=1820380&view=diff
>>>
>>> ==============================================================================
>>> --- jmeter/trunk/bin/jmeter (original)
>>> +++ jmeter/trunk/bin/jmeter Sat Jan  6 09:47:30 2018
>>> @@ -123,7 +123,8 @@ esac
>>>    HEAP="-Xms512m -Xmx512m -XX:MaxMetaspaceSize=256m"
>>>      # Set language
>>> -# JMETER_LANGUAGE="-Duser.language=en -Duser.region=EN"
>>> +# Default to en_EN
>>> +JMETER_LANGUAGE="-Duser.language=en -Duser.region=EN"
>>>      # Uncomment this to generate GC verbose file with Java prior to 9
>>>    # VERBOSE_GC="-verbose:gc -Xloggc:gc_jmeter_%p.log -XX:+PrintGCDetails
>>> -XX:+PrintGCCause -XX:+PrintTenuringDistribution -XX:+PrintHeapAtGC
>>> -XX:+PrintGCApplicationConcurrentTime -XX:+PrintAdaptiveSizePolicy
>>> -XX:+PrintGCApplicationStoppedTime -XX:+PrintGCDateStamps"
>>>
>>> Modified: jmeter/trunk/bin/jmeter.bat
>>> URL:
>>> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.bat?rev=1820380&r1=1820379&r2=1820380&view=diff
>>>
>>> ==============================================================================
>>> --- jmeter/trunk/bin/jmeter.bat (original)
>>> +++ jmeter/trunk/bin/jmeter.bat Sat Jan  6 09:47:30 2018
>>> @@ -27,7 +27,9 @@ rem
>>>    rem   =====================================================
>>>      setlocal
>>> -rem set JVM_ARGS=-Duser.language="en" -Duser.region="EN"
>>> +# Set language
>>> +# Default to en_EN
>>> +set JVM_ARGS=-Duser.language="en" -Duser.region="EN"
>>>    rem Minimal version to run JMeter
>>>    set MINIMAL_VERSION=1.8.0
>>>
>>> Modified: jmeter/trunk/xdocs/changes.xml
>>> URL:
>>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1820380&r1=1820379&r2=1820380&view=diff
>>>
>>> ==============================================================================
>>> --- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
>>> +++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Jan  6 09:47:30 2018
>>> @@ -87,6 +87,10 @@ Summary
>>>        <li>Following classes have been dropped
>>> (<code>org.apache.jmeter.functions.util.ArgumentEncoder</code>,
>>> <code>org.apache.jmeter.functions.util.ArgumentDecoder</code>), see
>>> <pr>335</pr></li>
>>>        <li>In JMS Point-to-Point sampler, setting timeout to 0 will now
>>> mean infinite timeout while previously it would be switched to 2000 ms, see
>>> <bugzilla>61829</bugzilla></li>
>>>        <li>When Assertions are at different scopes, they are executed
>>> starting with the most OUTER one to the most INNER one. See
>>> <bugzilla>61846</bugzilla></li>
>>> +    <li>JMeter now starts by default using English locale. This change
is
>>> due to missing translations in many supported languages.
>>> +        You can change locale by modifying in jmeter and jmeter.bat
>>> <code>JVM_ARGS</code> system property values.
>>> +        We'd also be very grateful if you can contribute translations in
>>> supported languages.
>>> +    </li>
>>>    </ul>
>>>    <!-- =================== Improvements =================== -->
>>>    @@ -194,6 +198,7 @@ Summary
>>>        <li><bug>61920</bug>Plugins : Add ability to listen
to Test Plan
>>> loading/closing. Contributed by Peter Doornbosch
>>> (https://bitbucket.org/pjtr/)</li>
>>>        <li><bug>61935</bug>Plugins : Let GUI component (dynamically)
decide
>>> whether it can be added via the menu or not. Contributed by Peter Doornbosch
>>> (https://bitbucket.org/pjtr/)</li>
>>>        <li><bug>61969</bug>When changing LAF through GUI, user
should be
>>> informed that it is better to restart</li>
>>> +    <li><bug>61970</bug>JMeter now uses english as default
locale to
>>> avoid missing translations in some locales make UI look weird</li>
>>>    </ul>
>>>      <ch_section>Non-functional changes</ch_section>
>>>
>>>


Mime
View raw message