Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
MIME-Version: 1.0
In-Reply-To: <CACR6oqqbXt1Cp2t_Q+8vNGYq-KrxjBzB4iMG1ePu9DHmZ9AW_A@mail.gmail.com>
References: <CACR6oqovCxgQuB6tu_DoPbsoE8JhGL59J1D6Lx0K04Ru=3vh9A@mail.gmail.com>
 <CABWbpFe4SFBnw9qwCjHdtAV40yobiPgkHDnnqFa=MDwn30KroQ@mail.gmail.com>
 <CACR6oqpdCY5zdewTf672y3Z2-Q+h-15xAjq1B-_RD1a1OwVs9Q@mail.gmail.com>
 <CABWbpFfzZR8dTdmfdzrvm7SKPa0+G3MR2CvWQ674qL8JiEvUzA@mail.gmail.com>
 <CABceovzgM28gHVXx_FA+_hu3BPcjE3nS4B-zASYAunE1aD0fDQ@mail.gmail.com>
 <CAH9fUpZYTJw-UfGWXckRbCVMuaJ98_XfsznresTRwTai3bQ5xg@mail.gmail.com>
 <CACR6oqoXVVO9qjUursbrLjQ46mEJDfSWzc2PY8=DyA4mh+NhZA@mail.gmail.com>
 <CABceovzmvVdAr2i=9utgw_PKPN5M_Wv=puSpYH7PCrU4gsBK2w@mail.gmail.com>
 <CACR6oqq+kypo-4Y4M4U0rTYO+4hwB8Zdg1DwcRS6wK393AAmrg@mail.gmail.com>
 <CABceovwyYpxpw-k5FNvySS76J1bapuV+bRD_pahGP7r+4zHVDg@mail.gmail.com>
 <CABceovx88Ny1V_k9J7mBHRJ01THQjtqd5n9FR0Kax0svMBtVLg@mail.gmail.com> <CACR6oqqbXt1Cp2t_Q+8vNGYq-KrxjBzB4iMG1ePu9DHmZ9AW_A@mail.gmail.com>
From: Philippe Mouawad <philippe.mouawad@gmail.com>
Date: Wed, 20 Dec 2017 10:51:41 +0100
Message-ID: <CAH9fUpZnye+kvUR6zG8e-AFDyrnNyMFDE242b5MfA4AYzAN+cg@mail.gmail.com>
Subject: Re: Menu item ordering
To: dev@jmeter.apache.org
Content-Type: multipart/alternative; boundary="001a1142a180cfd04a0560c2873d"
archived-at: Wed, 20 Dec 2017 09:51:48 -0000

--001a1142a180cfd04a0560c2873d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Graham,
Thanks for  your ideas and contribution.
PRs merged , I like the new look .
I've reworked a bit the sort order to be able to move elements we will
possibly deprecated  at the bottom.

Regards

On Thu, Dec 14, 2017 at 1:59 PM, Graham Russell <graham@ham1.co.uk> wrote:

> I've submitted a PR (https://github.com/apache/jmeter/pull/360) for the
> menu re-ordering.
> Testing, critiques and any major disagreements with my proposed order ver=
y
> much welcomed!
>
> I've tried to keep it simple for the time being. We could add another ite=
m
> to the annotation, e.g. groups, which could then define more than the
> current (specifically ordered vs. the rest).
>
> The search box might take me a while, my swing GUI skills are lacking, an=
d
> I might not get time before Christmas to work on it.
>
> I'm starting to like the idea of grouping plugins in their own sub-menu a=
s
> this might make it more obvious for beginners and easier if you need a lo=
t
> of plugins, then again, a palette with up to 10-15 things "ought to be
> enough for anybody".
>
> Thanks
>
> Graham
>
>
> On 12 December 2017 at 16:58, Vincent HERILIER <vherilier@gmail.com>
> wrote:
> > Maybe could we propose different layouts (full flat (default ?), full
> > grouped, plugin only... defined by a property) mixed with LRU
> proposition,
> > Search box... accordingly to user preferences/habits/needs ?
> >
> >
> >
> > Le mar. 12 d=C3=A9c. 2017 =C3=A0 16:40, Vincent HERILIER <vherilier@gma=
il.com> a
> > =C3=A9crit :
> >
> >> In the PR, I proposed, I grouped JMeter native elements as example, bu=
t
> >> the PR insured to let some elements at their initial place (JMEter one=
s
> to
> >> keep its current usability) and allow others to be grouped (3rd party
> ones
> >> if required and proposed by their related maintainers).
> >> So it was just allowing the feature, it didn't ordered it.
> >>
> >> Maybe it could be no more compatible with some evolutions you planned
> and
> >> that avoids it anyway.
> >> Or we could try to make these approaches complementary too...
> >>
> >> Anyway, I stay really interested in JMeter usability improvement.
> >>
> >> Le mar. 12 d=C3=A9c. 2017 =C3=A0 16:15, Graham Russell <graham@ham1.co=
.uk> a
> =C3=A9crit
> :
> >>
> >>> Ah, I didn't appreciate the use case you had.
> >>>
> >>> I still think the additional menu groupings would be detrimental to
> more
> >>> common use cases.
> >>>
> >>> Perhaps we can keep plugin menus ordered separated from the native on=
es
> >>> this might help slightly. I will make sure I test my changes with som=
e
> >>> plugins!
> >>>
> >>> I was thinking to keep a LRU list in the search box results which
> should
> >>> speed things up for most use cases.
> >>>
> >>> Graham
> >>>
> >>>
> >>> On 12 December 2017 at 14:15, Vincent HERILIER <vherilier@gmail.com>
> >>> wrote:
> >>> > I clearly understand your points of view.
> >>> >
> >>> > But with plugins used in my case (and average 300 testers) which
> bring
> >>> > average 40 config elements and 90 samplers, they are mixed (with
> JMeter
> >>> > native ones too) for complex and cross-protocol flows we would like
> to
> >>> > simulate (average 15 protocols - new , redefined protocols or serve=
r
> >>> side
> >>> > part - for our needs coverage).
> >>> >
> >>> > Reconfiguring a palette does not really solve my issue because the
> range
> >>> of
> >>> > required elements changes often or is wide each time.
> >>> > Loading and using a search box often will not really a gain of time
> too.
> >>> >
> >>> > That's why a protocol grouping is IMHO and in my specific use-case
> more
> >>> > accurate and quickly usable.
> >>> > I hope beiing wrong and I'm waiting for a quicker menu navigation
> >>> mechanism
> >>> > even it is not a submenu one ;).
> >>> >
> >>> > Thanks for all the work you provide to improve JMeter.
> >>> >
> >>> > Vincent
> >>> >
> >>> > Le mar. 12 d=C3=A9c. 2017 =C3=A0 14:29, Graham Russell <graham@ham1=
.co.uk> a
> >>> =C3=A9crit :
> >>> >
> >>> >> I agree with Phillipe that adding more menus, and therefore steps =
to
> >>> >> get to items you need (key presses or mouse moves) and items to re=
ad
> >>> >> is not an improvement.
> >>> >>
> >>> >> I like the idea of a configurable palette (with some sensible
> >>> >> defaults), much easier for beginners.
> >>> >>
> >>> >> This still requires use of the mouse, so for more advanced users,
> what
> >>> >> do we think of introducing a "find/search"?
> >>> >> Pressing ctrl+shift+a loads a pop-up search box, as you type it
> >>> >> filters the list and you click/press enter on the one you want and
> >>> >> it's added to the tree.
> >>> >>
> >>> >> On 12 December 2017 at 13:11, Philippe Mouawad
> >>> >> <philippe.mouawad@gmail.com> wrote:
> >>> >> > Hello,
> >>> >> > I am personally against an additional level in the popup menu as
> it
> >>> would
> >>> >> > be a loss of time.
> >>> >> > If it's about reorganizing the menu order to put most popular on=
es
> on
> >>> >> top,
> >>> >> > why not.
> >>> >> >
> >>> >> > A configurable palette in the right or bottom left (now we  have
> >>> dropped
> >>> >> > workbench)  might be a better alternative. User could put here t=
he
> >>> >> elements
> >>> >> > he uses the most.
> >>> >> >
> >>> >> > Regards
> >>> >> >
> >>> >> >
> >>> >> >
> >>> >> > On Tue, Dec 12, 2017 at 2:05 PM, Vincent HERILIER <
> >>> vherilier@gmail.com>
> >>> >> > wrote:
> >>> >> >
> >>> >> >> Hi,
> >>> >> >>
> >>> >> >> I already proposed a PR in that way (
> >>> >> >> https://github.com/apache/jmeter/pull/236) and I'm still
> >>> interested in
> >>> >> >> having the capability to group some elements ,per protocol clas=
s
> for
> >>> >> >> example, to reduce the amount of different menus entries shown.
> >>> >> >>
> >>> >> >> Vincent
> >>> >> >>
> >>> >> >> Le mar. 12 d=C3=A9c. 2017 =C3=A0 10:07, Antonio Gomes Rodrigues=
 <
> >>> ra0077@gmail.com>
> >>> >> a
> >>> >> >> =C3=A9crit :
> >>> >> >>
> >>> >> >> > Hi,
> >>> >> >> >
> >>> >> >> > About advanced mode, some code has been written and maybe we
> need
> >>> to
> >>> >> >> remove
> >>> >> >> > it and discuss again and finish it.
> >>> >> >> >
> >>> >> >> > Yes, it's hockey.
> >>> >> >> >
> >>> >> >> >
> >>> >> >> > For the moment I have few free time but I probably write some
> blog
> >>> >> post
> >>> >> >> > (Apache provide blog) about some features.
> >>> >> >> >
> >>> >> >> > Thanks to the PR
> >>> >> >> >
> >>> >> >> > Antonio
> >>> >> >> >
> >>> >> >> >
> >>> >> >> > 2017-12-11 21:00 GMT+01:00 Graham Russell <graham@ham1.co.uk>=
:
> >>> >> >> >
> >>> >> >> > > Ah ok, I noticed something about advanced mode and wondered
> what
> >>> it
> >>> >> >> > meant,
> >>> >> >> > > probably worth tidying up?
> >>> >> >> > >
> >>> >> >> > > I think those hotkeys should be more prominently documented=
,
> I
> >>> only
> >>> >> >> > > recently discovered them, or are there other shortcuts you
> were
> >>> >> >> referring
> >>> >> >> > > to?
> >>> >> >> > >
> >>> >> >> > > I will attempt a PR with a proof of concept in the coming
> week.
> >>> >> >> > >
> >>> >> >> > > Thanks
> >>> >> >> > >
> >>> >> >> > > Graham
> >>> >> >> > >
> >>> >> >> > > On Mon, 11 Dec 2017, 09:21 Antonio Gomes Rodrigues, <
> >>> >> ra0077@gmail.com>
> >>> >> >> > > wrote:
> >>> >> >> > >
> >>> >> >> > > > Hi,
> >>> >> >> > > >
> >>> >> >> > > > Sometime ago we have discuss to have an advanced mode wit=
h
> all
> >>> >> >> options
> >>> >> >> > > and
> >>> >> >> > > > an basic mode with only the essentials. Unfortunately the=
re
> >>> was
> >>> no
> >>> >> >> > > > consensus
> >>> >> >> > > >
> >>> >> >> > > > For the moment we have shortcuts
> >>> >> >> > > >
> >>> >> >> > > > +1 for your solution
> >>> >> >> > > >
> >>> >> >> > > > Antonio
> >>> >> >> > > >
> >>> >> >> > > >
> >>> >> >> > > > 2017-12-10 19:36 GMT+01:00 Graham Russell <
> graham@ham1.co.uk
> >>> >:
> >>> >> >> > > >
> >>> >> >> > > > > Hi all
> >>> >> >> > > > >
> >>> >> >> > > > > Currently the menus are ordered alphabetically, which i=
s
> >>> fine
> >>> >> for
> >>> >> >> > > > > small menus, and better than not at all for the large
> ones,
> >>> >> >> however I
> >>> >> >> > > > > think we can do better.
> >>> >> >> > > > >
> >>> >> >> > > > > If the menu has more than 4-5 items in it I think we
> should
> >>> >> split
> >>> >> >> it
> >>> >> >> > > > > up into chunks of 5-7 with the most popular (e.g. HTTP
> >>> Request
> >>> >> >> > > > > Sampler) at the top. I hope this would ease a bit of RS=
I
> for
> >>> >> users
> >>> >> >> > and
> >>> >> >> > > > > help improve the usability.
> >>> >> >> > > > >
> >>> >> >> > > > > Any thoughts?
> >>> >> >> > > > >
> >>> >> >> > > > > Having looked at the code it seems the menus are built =
by
> >>> >> looking
> >>> >> >> at
> >>> >> >> > > > > the classes, does adding an annotation with "sort order=
"
> and
> >>> >> maybe
> >>> >> >> > > > > "group" make sense or is there a better way to dictate
> the
> >>> >> order of
> >>> >> >> > > > > items in the menus?
> >>> >> >> > > > >
> >>> >> >> > > > > Thanks
> >>> >> >> > > > >
> >>> >> >> > > > > Graham
> >>> >> >> > > > >
> >>> >> >> > > >
> >>> >> >> > >
> >>> >> >> >
> >>> >> >>
> >>> >> >
> >>> >> >
> >>> >> >
> >>> >> > --
> >>> >> > Cordialement.
> >>> >> > Philippe Mouawad.
> >>> >>
> >>>
> >>
>


--=20
Cordialement.
Philippe Mouawad.

--001a1142a180cfd04a0560c2873d--