jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ham1 <...@git.apache.org>
Subject [GitHub] jmeter pull request #345: Checkstyle
Date Wed, 29 Nov 2017 22:59:56 GMT
GitHub user ham1 opened a pull request:

    https://github.com/apache/jmeter/pull/345

    Checkstyle

    ## Description
    * Updated to latest checkstyle (v8.5)
    * Added many more rules to checkstyle
    * Included checking of test files and more file types
    
    ## Motivation and Context
    Automatically enforcing some of the coding standards/conventions helps improve readability
and prevents commits like "Tab police" or commits which only change formatting thus cluttering
the history (or leaving it in an inconsistent state to micro-annoy subsequent readers).
    
    ## How Has This Been Tested?
    `ant clean checkstyle -Djava.awt.headless=true -Dskip.bug52310=true -Dskip.test_https=true
test`
    
    ## Screenshots (if appropriate):
    
    ## Types of changes
    <!--- What types of changes does your code introduce? Delete as appropriate -->
    - Dev enhancement
    
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
    - [x] My code follows the [code style][style-guide] of this project.
    - [x] I have updated the documentation accordingly.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ham1/jmeter checkstyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #345
    
----
commit 2211ef54083c63408c5d26a6b3efc094217a212d
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-20T23:15:30Z

    Added JavaDoc check for methods

commit c522c65a56e7235d9ff08863a06f78fd46ed677c
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-23T22:25:18Z

    Added checkstyle rules: AvoidStarImport, Redundant and Unused Import

commit 2c42a045f23086f28530ebc5131824c6749a3094
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-26T10:18:10Z

    Updated to latest checkstyle, 8.4. Included test and properties files.
    Added more rules, e.g. max file length, max 2 blank lines, no empty catch blocks.

commit f22813aeaa1425a145481d6d997443b783391246
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-26T19:59:09Z

    Added IllegalThrows and fixed issues

commit 7833686519d94f3746918aa16d2f7bbd51002c37
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-27T21:45:45Z

    WIP: MissingSwitchDefault and ModifiedControlVariable

commit 1b1cc5bde4118dda7e11d076fdef832e02fa3996
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-28T01:52:42Z

    Added and fixed MultipleVariableDeclarations, NestedForDepth, NestedIfDepth and NestedTryDepth

commit 02d9cb7a9426c8cf6ba099caf1b7d2fbdb57f15b
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-28T02:12:43Z

    Removed commented out surpression

commit 8a50df25c32158abbd854c4c49765b440129c7a3
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-28T02:18:35Z

    Updated to checkstyle 8.5

commit c531cd0cf2cee82ba388f76e0b18bd402acc24d2
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-29T00:44:07Z

    Added more checkstyle rules, and fixes:
    OneStatementPerLine
    SimplifyBooleanExpression
    SimplifyBooleanReturn
    StringLiteralEquality
    SuperFinalize
    UnnecessaryParentheses

commit 7b95f6a8e77b8dcd6e76694b93529bd4ad0edb1b
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-29T10:15:33Z

    Formatted darcula_theme.xml with a 2 space indent and added NL at EOF

commit 44fc9d3b9431fdb106b2d07016db9e606f87f664
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-29T15:19:18Z

    Fix mistake caught by unit tests, hurrah for unit tests.

----


---

Mime
View raw message