jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ham1 <...@git.apache.org>
Subject [GitHub] jmeter pull request #329: Expansion of "Add expand/collapse all menu in rend...
Date Tue, 14 Nov 2017 23:05:42 GMT
GitHub user ham1 opened a pull request:

    https://github.com/apache/jmeter/pull/329

    Expansion of "Add expand/collapse all menu in render XML view" (PR #294)

    ## Description
    
    Update and expansion to PR #294. I hope @max3163 doesn't mind. It improves upon the UX
of the original (good) idea by having the right click also select the node, rather than right
click bring up the menu but not changing the selected node which felt counter intuitive.
    
    ## Motivation and Context
    
    Makes exploring the XML results far easier, especially for large documents.
    
    ## How Has This Been Tested?
    
    Manually downloading a few different xml docs and right clicking, expanding and collapsing
in various places.
    
    ## Screenshots (if appropriate):
    Right clicking on the element, selects it and brings up the menu:
    ![Right-click on element](https://user-images.githubusercontent.com/3393038/32809390-93ddce74-c98e-11e7-98a0-ba6db1814109.png)
    Expands all:
    ![Expand All](https://user-images.githubusercontent.com/3393038/32809399-99c05500-c98e-11e7-83e9-a334aedd692b.png)
    
    ## Types of changes
    - New feature (non-breaking change which adds functionality)
    
    ## Checklist:
    - [x] My code follows the [code style][style-guide] of this project.
    - [x] I have updated the documentation accordingly.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ham1/jmeter pr_294

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/329.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #329
    
----
commit f3819f9e94e6e9890f0483f645f214137867e547
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-14T22:29:38Z

    formatting

commit afb038ae7341f6448c1573c073d5f140371c1e82
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-14T22:31:10Z

    Right click XML view will select node and show menu for collapse/expand.

commit 094716219c6a22bebf16048946b291d9dbab467e
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-14T23:03:55Z

    Updated docs

----


---

Mime
View raw message