jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ham1 <...@git.apache.org>
Subject [GitHub] jmeter pull request #327: Utilising more modern Java, simplifying code and f...
Date Mon, 13 Nov 2017 00:40:07 GMT
GitHub user ham1 opened a pull request:

    https://github.com/apache/jmeter/pull/327

    Utilising more modern Java, simplifying code and formatting code and comments

    ## Description
    Three commits covering three types of change:
    - Formatting and comment tidy up
    - Use modern Java, streams, computeIfAbsent etc.
    - Simplify code and reduce nesting
    
    Feel free to take only some, I did this while trying to better understand the code.
    
    ## Motivation and Context
    Improve readability etc.
    
    ## How Has This Been Tested?
    Ant test, no functional changes.
    
    ## Screenshots (if appropriate):
    
    ## Types of changes
    <!--- What types of changes does your code introduce? Delete as appropriate -->
    - Code improvement
    
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
    - [x] My code follows the [code style][style-guide] of this project.
    - [x] I have updated the documentation accordingly.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ham1/jmeter formatting_whitespace_etc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/327.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #327
    
----
commit c12f08f74e83e8959f83792f70cfe8c1500f5a7a
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-11T23:59:10Z

    formatting and comment tidy

commit 0274d4139e05bdaf6884790839f4748f253b3bdb
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-12T23:07:44Z

    Used modern Java features e.g. streams, computeIfAbsent and enhanced for loops.

commit e1c0dca060d22fe52e657b94c21fb1758741b648
Author: Graham Russell <graham@ham1.co.uk>
Date:   2017-11-12T23:33:12Z

    Simplify code and reduce nesting

----


---

Mime
View raw message